r79633 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79632‎ | r79633 | r79634 >
Date:23:01, 4 January 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Logged in users (not anons), can comment (don't need coder right), but anons can't

Change query to match, and fix string built
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRepoListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRepoListView.php
@@ -24,11 +24,13 @@
2525 $links[] = "[[Special:Code/$name/comments|" . wfMsgHtml( 'code-notes' ) . "]]";
2626 $links[] = "[[Special:Code/$name/statuschanges|" . wfMsgHtml( 'code-statuschanges' ) . "]]";
2727 if ( $wgUser->getId() ) {
28 - $author = $repo->wikiUserAuthor( $wgUser->getName() );
 28+ $userName = $wgUser->getName();
 29+ $author = $repo->wikiUserAuthor( $userName );
2930 if ( $author !== false ) {
3031 $links[] = "[[Special:Code/$name/author/$author|" . wfMsgHtml( 'code-mycommits' ) . "]]";
31 - $links[] = "[[Special:Code/$name/comments/$author|" . wfMsgHtml( 'code-mycomments' ) . "]]";
3232 }
 33+
 34+ $links[] = "[[Special:Code/$name/comments/author/$userName|" . wfMsgHtml( 'code-mycomments' ) . "]]";
3335 }
3436 $links[] = "[[Special:Code/$name/tag|" . wfMsgHtml( 'code-tags' ) . "]]";
3537 $links[] = "[[Special:Code/$name/author|" . wfMsgHtml( 'code-authors' ) . "]]";

Follow-up revisions

RevisionCommit summaryAuthorDate
r79635Followup r79633, anyone with the codereview-post-comment can comment. So they...reedy23:26, 4 January 2011

Comments

#Comment by Hashar (talk | contribs)   12:08, 11 March 2011

reverted by r79635

Status & tagging log