r79557 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79556‎ | r79557 | r79558 >
Date:04:05, 4 January 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 26560) On allusers if limit < total number of users, last user gets duplicate

If $lastUserData is set to null, it won't get added again!
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -160,6 +160,9 @@
161161 if ( is_array( $lastUserData ) ) {
162162 $fit = $result->addValue( array( 'query', $this->getModuleName() ),
163163 null, $lastUserData );
 164+
 165+ $lastUserData = null;
 166+
164167 if ( !$fit ) {
165168 $this->setContinueEnumParameter( 'from',
166169 $this->keyToTitle( $lastUserData['name'] ) );
Index: trunk/phase3/RELEASE-NOTES
@@ -69,6 +69,7 @@
7070 * (bug 25767) Add userrights properties to allusers and users query lists
7171 * (bug 26558) list=allusers auprop=groups does not list groups a user is automatically a member of
7272 * (bug 26559) list=allusers auprop=rights does not match list=users usprop=rights
 73+* (bug 26560) On allusers if limit < total number of users, last user gets duplicate
7374
7475 === Languages updated in 1.18 ===
7576

Follow-up revisions

RevisionCommit summaryAuthorDate
r82714MFT r79557 due to all the duplicate bug reportsreedy11:38, 24 February 2011
r82715MFT r79557reedy11:41, 24 February 2011

Comments

#Comment by Reedy (talk | contribs)   11:51, 22 February 2011

Tagging for 1.17 and 1.17wmf as it resulted in a duplicate bug 27627

Status & tagging log