r79526 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79525‎ | r79526 | r79527 >
Date:20:41, 3 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Move comment about groups potentially returning less results from server.

Comment out description line about rights from ApiQueryUsers, as that prop doesn't exist (Might do in future. Possible artifact from large scale comment addition?)
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -243,10 +243,10 @@
244244 'prop' => array(
245245 'What pieces of information to include.',
246246 ' blockinfo - Adds the information about a current block on the user',
247 - ' groups - Lists groups that the user is in',
 247+ ' groups - Lists groups that the user is in. This uses more server resources and may return fewer results than the limit',
248248 ' editcount - Adds the edit count of the user',
249249 ' registration - Adds the timestamp of when the user registered',
250 - '`groups` property uses more server resources and may return fewer results than the limit' ),
 250+ ),
251251 'limit' => 'How many total user names to return',
252252 'witheditsonly' => 'Only list users who have made edits',
253253 );
Index: trunk/phase3/includes/api/ApiQueryUsers.php
@@ -273,7 +273,7 @@
274274 'What pieces of information to include',
275275 ' blockinfo - Tags if the user is blocked, by whom, and for what reason',
276276 ' groups - Lists all the groups the user(s) belongs to',
277 - ' rights - Lists all the rights the user(s) has',
 277+ //' rights - Lists all the rights the user(s) has',
278278 ' editcount - Adds the user\'s edit count',
279279 ' registration - Adds the user\'s registration timestamp',
280280 ' emailable - Tags if the user can and wants to receive e-mail through [[Special:Emailuser]]',

Status & tagging log