r79525 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79524‎ | r79525 | r79526 >
Date:20:39, 3 January 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
Followup r79522: bugfix for datetimepicker
Modified paths:
  • /trunk/extensions/SemanticFormsInputs/SFI_Inputs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticFormsInputs/SFI_Inputs.php
@@ -874,7 +874,7 @@
875875
876876 $other_args["part of dtp"] = true;
877877
878 - $jsAttribs = array();
 878+ $jsattribs = array();
879879
880880 // if we have to show a reset button
881881 if ( array_key_exists( 'show reset button', $other_args ) ||
@@ -908,9 +908,11 @@
909909 // insert the code of the JS init function into the pages code
910910 $wgOut->addScript('<script type="text/javascript">' . $jstext . '</script>');
911911
 912+ $separator = strpos($cur_value, " ");
 913+
912914 $html = '<span class="inputSpan' . ($is_mandatory ? ' mandatoryFieldSpan' : '') . '">' .
913 - self::jqDatePickerHTML($cur_value, $input_name, $is_mandatory, $is_disabled, $other_args) . " " .
914 - self::timepickerHTML($cur_value, $input_name, $is_mandatory, $is_disabled, $other_args) .
 915+ self::jqDatePickerHTML(substr($cur_value, 0, $separator), $input_name, $is_mandatory, $is_disabled, $other_args) . " " .
 916+ self::timepickerHTML(substr($cur_value, $separator + 1), $input_name, $is_mandatory, $is_disabled, $other_args) .
915917 Xml::element("input",
916918 array(
917919 "id" => "input_{$sfgFieldNum}",

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79522new input type datetimepickerfoxtrott20:18, 3 January 2011

Status & tagging log