r79462 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79461‎ | r79462 | r79463 >
Date:00:10, 2 January 2011
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Fix broken blacklisting code from r79363

Problem reported by Krinkle -- the code I copy-pasted from the wiki page
was wrong, and apparently I didn't test properly in Opera.
Modified paths:
  • /trunk/phase3/skins/common/mwsuggest.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/mwsuggest.js
——@@ -52,7 +52,7 @@
5353 * blacklist future versions too.
5454 */
5555 window.os_use_datalist = 'list' in document.createElement( 'input' )
56 - && $.client.profile.name != 'opera';
 56+ && $.client.profile().name != 'opera';
5757
5858 /** Timeout timer class that will fetch the results */
5959 window.os_Timer = function( id, r, query ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79363Enable mwsuggest datalist implementation...simetrical19:30, 31 December 2010

Comments

#Comment by Krinkle (talk | contribs)   00:12, 2 January 2011

Documentation was indeed wrong, I've updated it.

Status & tagging log