r79456 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79455‎ | r79456 | r79457 >
Date:23:06, 1 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Add missing $popts parameter, and pass it from r79455
Modified paths:
  • /trunk/phase3/includes/api/ApiParse.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiParse.php
@@ -97,7 +97,7 @@
9898 if ( $titleObj->getLatestRevID() === intval( $oldid ) ) {
9999 $articleObj = new Article( $titleObj );
100100
101 - $p_result = $this->getParsedSectionOrText( $articleObj, $titleObj, $pageid ) ;
 101+ $p_result = $this->getParsedSectionOrText( $articleObj, $titleObj, $popts, $pageid ) ;
102102
103103 } else {
104104 $text = $rev->getText( Revision::FOR_THIS_USER );
@@ -147,7 +147,7 @@
148148 $oldid = $articleObj->getRevIdFetched();
149149 }
150150
151 - $p_result = $this->getParsedSectionOrText( $articleObj, $titleObj, $pageid ) ;
 151+ $p_result = $this->getParsedSectionOrText( $articleObj, $titleObj, $popts, $pageid ) ;
152152 }
153153 } else {
154154 $titleObj = Title::newFromText( $title );
@@ -282,9 +282,10 @@
283283 * @param $articleObj Article
284284 * @param $titleObj Title
285285 * @param $pageId Int
 286+ * @param $pots ParserOptions
286287 * @return ParserOutput
287288 */
288 - private function getParsedSectionOrText( $articleObj, $titleObj, $pageId = null ) {
 289+ private function getParsedSectionOrText( $articleObj, $titleObj, $popts, $pageId = null ) {
289290 global $wgParser;
290291
291292 if ( $this->section !== false ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r814071.17: MFT r79454, r79455, r79456, r79536, r79727, r79733, r79773, r79774, r80...catrope19:18, 2 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79455Allow section to work with oldid when oldid == currentrevid (worked with olde...reedy23:01, 1 January 2011

Status & tagging log