r79428 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79427‎ | r79428 | r79429 >
Date:16:44, 1 January 2011
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Fix modern to use the tooltiponly attribute.
Modified paths:
  • /trunk/phase3/skins/Modern.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Modern.php
@@ -72,14 +72,7 @@
7373 echo ' class="'.htmlspecialchars($tab['class']).'"';
7474 }
7575 echo'><a href="'.htmlspecialchars($tab['href']).'"';
76 - # We don't want to give the watch tab an accesskey if the
77 - # page is being edited, because that conflicts with the
78 - # accesskey on the watch checkbox. We also don't want to
79 - # give the edit tab an accesskey, because that's fairly su-
80 - # perfluous and conflicts with an accesskey (Ctrl-E) often
81 - # used for editing in Safari.
82 - if( in_array( $action, array( 'edit', 'submit' ) )
83 - && in_array( $key, array( 'edit', 'watch', 'unwatch' ))) {
 76+ if( isset($tab["tooltiponly"]) && $tab["tooltiponly"] ) {
8477 echo $skin->tooltip( "ca-$key" );
8578 } else {
8679 echo $skin->tooltipAndAccesskey( "ca-$key" );

Comments

Status & tagging log