r79351 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79350‎ | r79351 | r79352 >
Date:16:56, 31 December 2010
Author:catrope
Status:ok
Tags:
Comment:
1.17: Fix fatal error due to undefined $dbr introduced in r57989. This was fixed in trunk in r79347 but that revision contains too many incompatible changes to be merged directly. 1.16 is also affected, will backport there too.
Modified paths:
  • /branches/REL1_17/phase3/includes/specials/SpecialLinkSearch.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/specials/SpecialLinkSearch.php
——@@ -117,6 +117,7 @@
118118 if ($rv === false) {
119119 // LinkFilter doesn't handle wildcard in IP, so we'll have to munge here.
120120 if (preg_match('/^(:?[0-9]{1,3}\.)+\*\s*$|^(:?[0-9]{1,3}\.){3}[0-9]{1,3}:[0-9]*\*\s*$/', $query)) {
 121+ $dbr = wfGetDB( DB_SLAVE );
121122 $rv = array( $prot . rtrim($query, " \t*"), $dbr->anyString() );
122123 $field = 'el_to';
123124 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r793541.16wmf4: Merge r79351 from the 1.17 branch, fixes fatal in Special:LinkSearchcatrope17:07, 31 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57989(bug 20275) Fixed LIKE queries on SQLite backend...maxsem19:53, 21 October 2009
r79347Follow-up r78786: the querypage branch merge threw SpecialLinkSearch back to ...catrope16:44, 31 December 2010

Status & tagging log