r79285 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79284‎ | r79285 | r79286 >
Date:19:18, 30 December 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r77654
These two files use constants from SeleniumTestConstants.php
I would be more confortable if all these defines were class variables, though.

Removed an empty statement.
Modified paths:
  • /trunk/phase3/tests/selenium/installer/MediaWikiRestartInstallationTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/MyContributionsTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/MyWatchListTestCase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/selenium/suites/MyContributionsTestCase.php
@@ -27,6 +27,8 @@
2828 *
2929 */
3030
 31+require_once dirname( dirname( __FILE__ ) ) . '/SeleniumTestConstants.php';
 32+
3133 class MyContributionsTestCase extends SeleniumTestCase {
3234
3335 // Verify user contributions
Index: trunk/phase3/tests/selenium/suites/MyWatchListTestCase.php
@@ -27,6 +27,7 @@
2828 *
2929 */
3030
 31+require_once dirname( dirname( __FILE__ ) ) . '/SeleniumTestConstants.php';
3132
3233 class MyWatchListTestCase extends SeleniumTestCase {
3334
Index: trunk/phase3/tests/selenium/installer/MediaWikiRestartInstallationTestCase.php
@@ -104,7 +104,6 @@
105105
106106 // Navigates to the previous page
107107 $this->assertEquals( "Database settings", $this->getText( LINK_DIV."h2" ));
108 - ;
109108
110109 // 'Connect to database' page
111110 parent::clickBackButton();

Follow-up revisions

RevisionCommit summaryAuthorDate
r79287Merging from r79285 thru r79286 of trunk to pick up reverted i18n fileawjrichards19:30, 30 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77654Added test scripts for wiki editor additional features and updated scripts on...nadeesha14:10, 3 December 2010

Status & tagging log