r79108 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79107‎ | r79108 | r79109 >
Date:15:54, 28 December 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Set $wgAdaptiveMessageCache for parserTests until NikeRabbit fixes r78179
Modified paths:
  • /trunk/phase3/tests/parser/parserTest.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTest.inc
——@@ -659,6 +659,7 @@
660660 'wgHtml5' => true,
661661 'wgWellFormedXml' => true,
662662 'wgAllowMicrodataAttributes' => true,
 663+ 'wgAdaptiveMessageCache' => true
663664 );
664665
665666 if ( $config ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78179Fix regression in r70657. Misplaced else condition was causing cache misses...nikerabbit13:18, 10 December 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   20:16, 30 March 2011

This doesn't appear to be needed any more. That is, the tests pass without it.

#Comment by Platonides (talk | contribs)   23:12, 30 March 2011

I think I completely disabled the message cache in a later revision.

#Comment by Tim Starling (talk | contribs)   12:23, 4 April 2011

I get 

Running test Interlanguage link, with prefix links... A database error has occurred.  Did you forget to run maintenance/update.php after upgrading?  See: [http://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script http://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script]
Query: SELECT  value,exptime  FROM `parsertest_objectcache`  WHERE keyname = 'testwiki-parsertest_:message-profiling'  LIMIT 1  
Function: SqlBagOStuff::get
Error: 1146 Table 'testwiki.parsertest_objectcache' doesn't exist (127.0.0.1:3306)

unless this is patched out.

#Comment by Platonides (talk | contribs)   17:49, 4 April 2011

Works for me. How is Wiki::restInPeace() getting called for you?

#Comment by Tim Starling (talk | contribs)   00:01, 5 April 2011

I'm not sure. It's stopped happening now.

#Comment by Platonides (talk | contribs)   22:56, 5 April 2011

Maybe you were running with an old parserTEst.inc version where $wgMemc = wfGetMainCache(); $messageMemc = wfGetMessageCacheStorage(); $parserMemc = wfGetParserCacheStorage(); still worked by reference.

In such case I do get a parsertest_objectcache' doesn't exist message (although not for message-profiling).

Status & tagging log