r78806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78805‎ | r78806 | r78807 >
Date:16:21, 22 December 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Simple commit trimming some trailing whitespace
Modified paths:
  • /trunk/phase3/includes/ImageGallery.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMostimages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialMostimages.php
@@ -34,7 +34,7 @@
3535 function __construct( $name = 'Mostimages' ) {
3636 parent::__construct( $name );
3737 }
38 -
 38+
3939 function isExpensive() { return true; }
4040 function isSyndicated() { return false; }
4141
Index: trunk/phase3/includes/ImageGallery.php
@@ -144,7 +144,7 @@
145145 * Add an image to the gallery.
146146 *
147147 * @param $title Title object of the image that is added to the gallery
148 - * @param $html String: additional HTML text to be shown. The name and size of the image are always shown.
 148+ * @param $html String: additional HTML text to be shown. The name and size of the image are always shown.
149149 */
150150 function add( $title, $html='' ) {
151151 if ( $title instanceof File ) {
@@ -276,7 +276,7 @@
277277 . htmlspecialchars( $img->getLastError() ) . '</div>';
278278 } else {
279279 $vpad = floor(( 30 + $this->mHeights - $thumb->height ) /2);
280 -
 280+
281281 $imageParameters = array(
282282 'desc-link' => true,
283283 'desc-query' => $descQuery
@@ -285,7 +285,7 @@
286286 if ( $text == '' ) {
287287 $imageParameters['alt'] = $nt->getText();
288288 }
289 -
 289+
290290 # Set both fixed width and height. Otherwise we might have problems
291291 # with the vertical centering of images where height<line-size
292292 $thumbhtml = "\n\t\t\t".

Comments

#Comment by Hashar (talk | contribs)   17:42, 7 March 2011

$ svn diff -x -bu -c 78806

Index: includes/specials/SpecialMostimages.php
===================================================================
Index: includes/ImageGallery.php
===================================================================
$

Marking OK

Status & tagging log