r78802 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78801‎ | r78802 | r78803 >
Date:16:16, 22 December 2010
Author:reedy
Status:resolved
Tags:
Comment:
Followup r78023, change usage of $style to $styles, not introduced in this revision, but was moved by it
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -2635,7 +2635,7 @@
26362636 $group = $resourceLoader->getModule( $name )->getGroup();
26372637 // Modules in groups named "other" or anything different than "user" or "site" will
26382638 // be placed in the "other" group
2639 - $styles[isset( $style[$group] ) ? $group : 'other'][] = $name;
 2639+ $styles[isset( $styles[$group] ) ? $group : 'other'][] = $name;
26402640 }
26412641 // Add tags created using legacy methods
26422642 $tags = $this->buildCssLinksArray();

Follow-up revisions

RevisionCommit summaryAuthorDate
r78933Revert r78023 and its follow-up r78802: change seems to have been made for so...catrope23:26, 23 December 2010
r78934Followup r78933: reapply r78802catrope23:28, 23 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78023Improves on r77693 by placing ResourceLoader "only styles" CSS links together...tparscal22:27, 7 December 2010

Status & tagging log