r78790 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78789‎ | r78790 | r78791 >
Date:14:53, 22 December 2010
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
Followup r7876: fix another E_STRICT: kill additional parameter in doQuery() override; I guess doQuery() must've had that third parameter before but doesn't have it anymore
Modified paths:
  • /trunk/phase3/includes/specials/SpecialLinkSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialLinkSearch.php
@@ -171,7 +171,7 @@
172172 /**
173173 * Override to check query validity.
174174 */
175 - function doQuery( $offset, $limit, $shownavigation=true ) {
 175+ function doQuery( $offset, $limit ) {
176176 global $wgOut;
177177 list( $this->mMungedQuery, ) = LinkSearchPage::mungeQuery( $this->mQuery, $this->mProt );
178178 if( $this->mMungedQuery === false ) {
@@ -180,7 +180,7 @@
181181 // For debugging
182182 // Generates invalid xhtml with patterns that contain --
183183 //$wgOut->addHTML( "\n<!-- " . htmlspecialchars( $this->mMungedQuery ) . " -->\n" );
184 - parent::doQuery( $offset, $limit, $shownavigation );
 184+ parent::doQuery( $offset, $limit );
185185 }
186186 }
187187

Follow-up revisions

RevisionCommit summaryAuthorDate
r78792Really do what r78790 claimed to do (fix E_STRICT in r78786)catrope15:00, 22 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78760Four more spaces, per r78759 CRplatonides00:06, 22 December 2010

Comments

#Comment by Catrope (talk | contribs)   14:57, 22 December 2010

Commit message should say r78786

#Comment by Nikerabbit (talk | contribs)   15:25, 22 December 2010

Actually the parameters were changed from $offset, $limit, $shownavigation=true to $limit, $offset = false;

Status & tagging log