r78595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78594‎ | r78595 | r78596 >
Date:05:32, 19 December 2010
Author:mah
Status:ok (Comments)
Tags:
Comment:
Not sure how I missed --scriptpath option since it was right above the wikiroot option I added, but I did. (ok, so I *do* know how I missed it, but it was a dumb mistake).
Modified paths:
  • /trunk/phase3/includes/installer/CliInstaller.php (modified) (history)
  • /trunk/phase3/maintenance/install.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CliInstaller.php
@@ -32,7 +32,6 @@
3333 'dbts2schema' => 'wgDBts2schema',
3434 'dbpath' => 'wgSQLiteDataDir',
3535 'scriptpath' => 'wgScriptPath',
36 - 'wikiroot' => 'wgScriptPath',
3736 'upgrade' => 'cliUpgrade', /* As long as it isn't $confItems
3837 * in LocalSettingsGenerator, we
3938 * should be fine. */
Index: trunk/phase3/maintenance/install.php
@@ -49,7 +49,6 @@
5050 $this->addOption( 'dbuser', 'The user to use for normal operations (wikiuser)', false, true );
5151 $this->addOption( 'dbpass', 'The pasword for the DB user for normal operations', false, true );
5252 $this->addOption( 'confpath', "Path to write LocalSettings.php to, default $IP", false, true );
53 - $this->addOption( 'wikiroot', "The URL to use for the wiki root (/wiki)", false, true );
5453 /* $this->addOption( 'dbschema', 'The schema for the MediaWiki DB in pg (mediawiki)', false, true ); */
5554 /* $this->addOption( 'dbtsearch2schema', 'The schema for the tsearch2 DB in pg (public)', false, true ); */
5655 /* $this->addOption( 'namespace', 'The project namespace (same as the name)', false, true ); */

Comments

#Comment by Krinkle (talk | contribs)   14:04, 19 December 2010

This is a partial revert of r78593

Status & tagging log