r78444 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78443‎ | r78444 | r78445 >
Date:17:58, 15 December 2010
Author:laner
Status:ok
Tags:
Comment:
Fixing errors introducted and pointed out in the code review for r78427.
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -1128,7 +1128,7 @@
11291129 foreach ( array_keys( $prefs ) as $key ) {
11301130 $attr = strtolower( $prefs[$key] );
11311131 if ( isset( $this->userInfo[0][$attr] ) ) {
1132 - $value = $this->userInfo[0][$attr];
 1132+ $value = $this->userInfo[0][$attr][0];
11331133 } else {
11341134 continue;
11351135 }
@@ -1147,7 +1147,7 @@
11481148 break;
11491149 case "realname":
11501150 $this->realname = $value;
1151 - $this->printDebug( "Retrieved realname ($this->realname) using attribute ($attr)", NONSENSITIVE );
 1151+ $this->printDebug( "Retrieved realname ($this->realname) using attribute ($prefs[$key])", NONSENSITIVE );
11521152 break;
11531153 }
11541154 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78427Clean up getPreferences, and ensure attributes are always lowercase.laner01:30, 15 December 2010

Status & tagging log