r78443 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78442‎ | r78443 | r78444 >
Date:17:51, 15 December 2010
Author:demon
Status:deferred
Tags:
Comment:
MFT part of r74967: fix for no user existing for an author, was causing pywikipedia's CR update failures
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/CodeReview/backend/CodeRevision.php
@@ -345,7 +345,7 @@
346346 $revisionAuthor = $revision->getWikiUser();
347347
348348 //Add the followup revision author if they have not already been added as a commentor (they won't want dupe emails!)
349 - if ( !array_key_exists( $revisionAuthor->getId(), $users ) ) {
 349+ if ( $revisionAuthor && !array_key_exists( $revisionAuthor->getId(), $users ) ) {
350350 $users[$revisionAuthor->getId()] = $revisionAuthor;
351351 }
352352

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74967* Let user receives its own comments by emails if already wants...hashar20:50, 18 October 2010

Status & tagging log