r78439 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78438‎ | r78439 | r78440 >
Date:14:23, 15 December 2010
Author:catrope
Status:ok
Tags:
Comment:
1.17: Merge some more revs from trunk: r78144, r78403, r78436
Modified paths:
  • /branches/REL1_17/phase3/includes/HTMLForm.php (modified) (history)
  • /branches/REL1_17/phase3/includes/api/ApiQueryInfo.php (modified) (history)
  • /branches/REL1_17/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/HTMLForm.php
@@ -1065,7 +1065,7 @@
10661066
10671067 # http://dev.w3.org/html5/spec/common-microsyntaxes.html#real-numbers
10681068 # with the addition that a leading '+' sign is ok.
1069 - if ( !preg_match( '/^(\+|\-)?\d+(\.\d+)?(E(\+|\-)?\d+)?$/i', $value ) ) {
 1069+ if ( !preg_match( '/^((\+|\-)?\d+(\.\d+)?(E(\+|\-)?\d+)?)?$/i', $value ) ) {
10701070 return wfMsgExt( 'htmlform-float-invalid', 'parse' );
10711071 }
10721072
@@ -1108,7 +1108,7 @@
11091109 # phone numbers when you know that they are integers (the HTML5 type=tel
11101110 # input does not require its value to be numeric). If you want a tidier
11111111 # value to, eg, save in the DB, clean it up with intval().
1112 - if ( !preg_match( '/^(\+|\-)?\d*$/', trim( $value ) )
 1112+ if ( !preg_match( '/^((\+|\-)?\d+)?$/', trim( $value ) )
11131113 ) {
11141114 return wfMsgExt( 'htmlform-int-invalid', 'parse' );
11151115 }
Index: branches/REL1_17/phase3/includes/api/ApiQueryInfo.php
@@ -87,7 +87,6 @@
8888 'unblock' => array( 'ApiQueryInfo', 'getUnblockToken' ),
8989 'email' => array( 'ApiQueryInfo', 'getEmailToken' ),
9090 'import' => array( 'ApiQueryInfo', 'getImportToken' ),
91 - 'patrol' => array( 'ApiQueryRecentChanges', 'getPatrolToken' ),
9291 );
9392 wfRunHooks( 'APIQueryInfoTokens', array( &$this->tokenFunctions ) );
9493 return $this->tokenFunctions;
Index: branches/REL1_17/phase3/languages/messages/MessagesEn.php
@@ -1300,9 +1300,9 @@
13011301 '''It has not yet been saved!'''",
13021302 'userjspreview' => "'''Remember that you are only testing/previewing your user JavaScript.'''
13031303 '''It has not yet been saved!'''",
1304 -'sitecsspreview' => "'''Remember that you are only previewing this global CSS.'''
 1304+'sitecsspreview' => "'''Remember that you are only previewing this CSS.'''
13051305 '''It has not yet been saved!'''",
1306 -'sitejspreview' => "'''Remember that you are only previewing this global JavaScript code.'''
 1306+'sitejspreview' => "'''Remember that you are only previewing this JavaScript code.'''
13071307 '''It has not yet been saved!'''",
13081308 'userinvalidcssjstitle' => "'''Warning:''' There is no skin \"\$1\".
13091309 Custom .css and .js pages use a lowercase title, e.g. {{ns:user}}:Foo/vector.css as opposed to {{ns:user}}:Foo/Vector.css.",

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78144Revert the addition of the patrol token from ApiQueryInfo from r78141; does n...btongminh21:42, 9 December 2010
r78403Remove the word global from the messages itselves, per r78230 CR.platonides21:57, 14 December 2010
r78436Better regexes for r78246.happy-melon13:33, 15 December 2010

Status & tagging log