r78435 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78434‎ | r78435 | r78436 >
Date:13:19, 15 December 2010
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Follow-up r78431 and r78432: Change prefix from 'lte' to 'livetranslate'. Less cryptic and makes sure that Translate extension catches ths message.
Prefix extension messages with the full extension name is more readable and searching on Special:AllMessages more successful :-)
Fix entry in translate config file
Modified paths:
  • /trunk/extensions/LiveTranslate/LiveTranslate.i18n.php (modified) (history)
  • /trunk/extensions/LiveTranslate/LiveTranslate.php (modified) (history)
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/LiveTranslate/LiveTranslate.i18n.php
@@ -15,7 +15,5 @@
1616 * @author Jeroen De Dauw
1717 */
1818 $messages['en'] = array(
19 - 'lte-desc' => 'Enables live translation of page content using the Google Translate service.',
20 -
21 -
22 -);
\ No newline at end of file
 19+ 'livetranslate-desc' => 'Enables live translation of page content using the Google Translate service',
 20+);
Index: trunk/extensions/LiveTranslate/LiveTranslate.php
@@ -35,7 +35,7 @@
3636 '[http://www.mediawiki.org/wiki/User:Jeroen_De_Dauw Jeroen De Dauw] for [http://www.wikiworks.com WikiWorks]',
3737 ),
3838 'url' => 'http://www.mediawiki.org/wiki/Extension:Live_Translate',
39 - 'descriptionmsg' => 'lte-desc'
 39+ 'descriptionmsg' => 'livetranslate-desc'
4040 );
4141
4242 $useExtensionPath = version_compare( $wgVersion, '1.16', '>=' ) && isset( $wgExtensionAssetsPath ) && $wgExtensionAssetsPath;
Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -665,7 +665,7 @@
666666 optional = lqt_rc_ellipsis
667667 ignored = lqt_header_warning_before_big
668668
669 -LiveTranslate
 669+Live Translate
670670
671671 Livelets
672672

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78431Adding stub for new LiveTranslate extensionjeroendedauw10:55, 15 December 2010
r78432Added LiveTranslate extensionjeroendedauw10:58, 15 December 2010

Comments

#Comment by Jeroen De Dauw (talk | contribs)   13:21, 15 December 2010

Thanks

Status & tagging log