r78420 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78419‎ | r78420 | r78421 >
Date:00:32, 15 December 2010
Author:reedy
Status:deferred (Comments)
Tags:
Comment:
Increased readability to r74808
Modified paths:
  • /trunk/extensions/OWALiteTracker/OWALiteTracker.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OWALiteTracker/OWALiteTracker.php
@@ -25,9 +25,15 @@
2626 if( !count( $wgOWAGeoTrackSites ) ) {
2727 return;
2828 }
29 - $text .= "<script> var includeOWA = false; if(Geo){";
 29+ $text = "<script> var includeOWA = false; if( Geo ){\n";
3030 foreach( $condition as $wgOWAGeoTrackSites ){
31 - $text .= "if (Geo.{$condition[0]} && Geo.{$condition[0]} == \"{$condition[1]}\"){ if(!includeOWA){includeOWA=true; importScriptURI( document.location.protocol +'//owa.wikimedia.org/owa/modules/base/js/owa.tracker-combined-min.js');} importScriptURI( document.location.protocol + '//owa.wikimedia.org/resources/{$condition[2]}');}";
 31+ $text .= "if (Geo.{$condition[0]} && Geo.{$condition[0]} == \"{$condition[1]}\"){
 32+ if( !includeOWA ) {
 33+ includeOWA = true;
 34+ importScriptURI( document.location.protocol + '//owa.wikimedia.org/owa/modules/base/js/owa.tracker-combined-min.js' );
3235 }
 36+ importScriptURI( document.location.protocol + '//owa.wikimedia.org/resources/{$condition[2]}');
 37+}";
 38+ }
3339 $text .= "}</script>";
3440 }
\ No newline at end of file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74808Fix typosnikerabbit16:55, 15 October 2010

Comments

#Comment by Reedy (talk | contribs)   00:34, 15 December 2010

Meant r78408

#Comment by Nikerabbit (talk | contribs)   07:59, 15 December 2010

Is it just me or is the diff view above horribly broken, with lots of empty lines (with Google Chrome)?

#Comment by P858snake (talk | contribs)   09:54, 15 December 2010

Looks fine, Fx win current stable

#Comment by Reedy (talk | contribs)   09:42, 15 December 2010

Think it's just you...

Mine seems fine 9.0.597.19 dev..

Status & tagging log