r78383 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78382‎ | r78383 | r78384 >
Date:16:26, 14 December 2010
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Per wikitech-l discussion: Move tests from maintenance/tests/ to tests/. They're not strictly maintenance scripts, and some people want to do a selective checkout that doesn't include the tests. There's still debate on whether we should include these in the release downloads, but we had a pretty firm consensus to move this.
Modified paths:
  • /trunk/phase3/tests/parser (added) (history)
  • /trunk/phase3/tests/parser/parserTest.inc (modified) (history)
  • /trunk/phase3/tests/parser/parserTestsParserHook.php (modified) (history)
  • /trunk/phase3/tests/parser/parserTestsStaticParserHook.php (modified) (history)
  • /trunk/phase3/tests/phpunit (added) (history)
  • /trunk/phase3/tests/phpunit/includes/HttpTest.php (replaced) (history)
  • /trunk/phase3/tests/selenium (added) (history)
  • /trunk/phase3/tests/selenium/SeleniumServerManager.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/AddContentToNewPageTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/AddNewPageTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/CreateAccountTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/DeletePageAdminTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/EmailPasswordTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/MediaWikiEditorConfig.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/MovePageTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/MyContributionsTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/MyWatchListTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/PageSearchTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/PreviewPageTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/SavePageTestCase.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/UserPreferencesTestCase.php (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r78384svn ci'd from the wrong directory, missed the deletes in r78383demon16:28, 14 December 2010
r78386Fix path changes from move in r78383demon16:33, 14 December 2010
r78441Followup r78383: deny tests from webdemon16:26, 15 December 2010

Comments

#Comment by Nikerabbit (talk | contribs)   17:18, 14 December 2010

The files are not properly protected from direct web access.

#Comment by Happy-melon (talk | contribs)   17:41, 16 December 2010

Done in r78441?

#Comment by Hashar (talk | contribs)   16:30, 16 February 2011

Assuming this one is 'resolved'

We have moved the test directory for a long time now and most issues seems to have been resolved by now. Does not seem to impact 1.17 which will not ship with tests.

Status & tagging log