r78295 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78294‎ | r78295 | r78296 >
Date:11:06, 13 December 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r78268, do it as Bryan suggested, not as how I'd interpretted it for some daft reason
Modified paths:
  • /trunk/phase3/includes/search/SearchEngine.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/search/SearchEngine.php
@@ -92,8 +92,6 @@
9393 public static function getNearMatch( $searchterm ) {
9494 $title = self::getNearMatchInternal( $searchterm );
9595
96 - wfRunHooks( 'SpecialSearchGomatch', array( &$title ) );
97 -
9896 wfRunHooks( 'SearchGetNearMatchComplete', array( $searchterm, &$title ) );
9997 return $title;
10098 }
Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -102,6 +102,7 @@
103103 }
104104 # If there's an exact or very near match, jump right there.
105105 $t = SearchEngine::getNearMatch( $term );
 106+ wfRunHooks( 'SpecialSearchGomatch', array( &$t ) );
106107 if( !is_null( $t ) ) {
107108 $wgOut->redirect( $t->getFullURL() );
108109 return;

Follow-up revisions

RevisionCommit summaryAuthorDate
r78297Followup r78295, seems I didn't even bother to rename it last timereedy12:38, 13 December 2010
r78323MFT SpecialSearchGo hook: r78320, r78268, r78295, r78297, r78320btongminh20:12, 13 December 2010
r79379*(bug 23720) CodeReview doesn't show ancient revisions for a path...reedy22:55, 31 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78268Followup r65114 (per CR cabal), remove SpecialSearchGomatch, replace with Spe...reedy18:57, 12 December 2010

Comments

#Comment by Bryan (talk | contribs)   12:28, 13 December 2010

Yeah that's what I meant, thanks.

You however forgot to rename the hook to SpecialSearchGo. You did already rename the hook in hooks.txt in r78268.

Status & tagging log