r78254 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78253‎ | r78254 | r78255 >
Date:15:55, 12 December 2010
Author:catrope
Status:reverted (Comments)
Tags:
Comment:
Folllowup r72866: use array syntax for rev_page = foo condition
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
——@@ -3749,7 +3749,7 @@
37503750 public function countRevisionsBetween( $old, $new ) {
37513751 $dbr = wfGetDB( DB_SLAVE );
37523752 return (int)$dbr->selectField( 'revision', 'count(*)',
3753 - 'rev_page = ' . intval( $this->getArticleId() ) .
 3753+ 'rev_page' => intval( $this->getArticleId() ) .
37543754 ' AND rev_id > ' . intval( $old ) .
37553755 ' AND rev_id < ' . intval( $new ),
37563756 __METHOD__
——@@ -3770,7 +3770,7 @@
37713771 $db = ( $flags & self::GAID_FOR_UPDATE ) ? wfGetDB( DB_MASTER ) : wfGetDB( DB_SLAVE );
37723772 $res = $db->select( 'revision', 'DISTINCT rev_user_text',
37733773 array(
3774 - 'rev_page = ' . $this->getArticleID(),
 3774+ 'rev_page' => $this->getArticleID(),
37753775 'rev_id > ' . (int)$fromRevId,
37763776 'rev_id < ' . (int)$toRevId
37773777 ), __METHOD__,

Follow-up revisions

RevisionCommit summaryAuthorDate
r78256This is not an array, but a parameter. Revert r78254. Is the precommit hook n...platonides16:15, 12 December 2010
r78257Redo r78254 without the syntax errorcatrope16:18, 12 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72866(bug 24007) Diff pages now mention the number of users having edited intermed...demon15:39, 12 September 2010

Comments

#Comment by Platonides (talk | contribs)   16:15, 12 December 2010

PHP Parse error: syntax error, unexpected T_DOUBLE_ARROW in includes/Title.php on line 3752. Reverted in r78256.

#Comment by Aaron Schulz (talk | contribs)   16:17, 12 December 2010

Hard to splot...a '.' should be a ',' :)

#Comment by Aaron Schulz (talk | contribs)   16:17, 12 December 2010

That should be "spot"...why am I typing in the dark?

Status & tagging log