r78235 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78234‎ | r78235 | r78236 >
Date:05:51, 12 December 2010
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
Follow up to r78234
Modified paths:
  • /trunk/extensions/Push/Push_Settings.php (modified) (history)
  • /trunk/extensions/Push/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/Push/includes/ext.push.tab.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Push/Push_Settings.php
@@ -28,5 +28,9 @@
2929 $egPushShowTab = false;
3030 $egPushIncTemplates = false;
3131
 32+$egPushAllowLogin = true;
 33+$egPushLodignUser = '';
 34+$egPushLodignPass = '';
 35+
3236 $egPushBulkWorkers = 3;
3337 $egPushBatchSize = 3;
Index: trunk/extensions/Push/RELEASE-NOTES
@@ -7,6 +7,7 @@
88 === Version 0.4 ===
99 2010-12-xx
1010
 11+* Added option to include templates used on the page to the push to the tab interface.
1112 * Added adittional info about target pages to the tab interface.
1213
1314 === Version 0.3 ===
Index: trunk/extensions/Push/includes/ext.push.tab.js
@@ -31,7 +31,7 @@
3232 this.disabled = true;
3333 this.innerHTML = mediaWiki.msg( 'push-button-pushing' );
3434
35 - if ( $('#checkIncTemplates:checked').val() !== null ) {
 35+ if ( $('#checkIncTemplates:checked').attr('checked') ) {
3636 var pages = window.wgPushTemplates;
3737 pages.unshift( $('#pageName').attr('value') );
3838 }
@@ -128,7 +128,7 @@
129129 setTimeout( function() {reEnableButton( sender );}, 1000 );
130130 }
131131 }
132 - );
 132+ );
133133 }
134134
135135 function reEnableButton( button ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78234Added include templates option to the push interface and changed the push api...jeroendedauw05:42, 12 December 2010

Comments

#Comment by Nikerabbit (talk | contribs)   11:52, 12 December 2010

Lodign??

#Comment by Jeroen De Dauw (talk | contribs)   12:10, 12 December 2010

Yeah obviously.

Will fix in my next commit :)

#Comment by Jeroen De Dauw (talk | contribs)   12:41, 12 December 2010

Fixed in r78242

Status & tagging log