r78071 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78070‎ | r78071 | r78072 >
Date:16:01, 8 December 2010
Author:bawolff
Status:ok
Tags:
Comment:
(bug 25512) Make it so that categories listed in the subcategory section of a page aren't prefixed with category: namespace.

This was originally caused by r53780. I'm presuming that it was accidental since that revision was about changing how lang converter is called.
Presumably no one noticed this since the bug does not appear if categorytree is installed.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -162,9 +162,10 @@
163163 */
164164 function addSubcategoryObject( Category $cat, $sortkey, $pageLength ) {
165165 // Subcategory; strip the 'Category' namespace from the link text.
 166+ $title = $cat->getTitle();
166167 $this->children[] = $this->getSkin()->link(
167 - $cat->getTitle(),
168 - null,
 168+ $title,
 169+ $title->getText(),
169170 array(),
170171 array(),
171172 array( 'known', 'noclasses' )
Index: trunk/phase3/RELEASE-NOTES
@@ -469,6 +469,7 @@
470470 * (bug 18372) $wgFileExtensions will now override $wgFileBlacklist
471471 * (bug 10871) Javascript and CSS pages in MediaWiki namespace are no longer treated
472472 as wikitext on preview.
 473+* (bug 25512) Subcategory list should not include category prefix for members.
473474
474475 === API changes in 1.17 ===
475476 * (bug 22738) Allow filtering by action type on query=logevent.

Follow-up revisions

RevisionCommit summaryAuthorDate
r780961.17: Merge recent fixes tagged on CodeReview, except for problematic revisio...catrope21:17, 8 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53780Follow up on r46020 and r46489. Improve the $wgContLang->convert() calling pr...philip15:54, 26 July 2009

Status & tagging log