r46489 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46488‎ | r46489 | r46490 >
Date:21:32, 28 January 2009
Author:brion
Status:ok
Tags:
Comment:
* (bug 17207) Fix regression breaking category page display on PHP 5.1
r46020 added a call to $wgContLang->convert() for category article listings, but mistakenly passed the title *object* instead of the text.
In PHP 5.2, this was silently converted to a string, but in older versions this would interpolate as something useless like "Object id #110".
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -189,7 +189,7 @@
190190 */
191191 function addPage( $title, $sortkey, $pageLength, $isRedirect = false ) {
192192 global $wgContLang;
193 - $titletext = $wgContLang->convert($title);
 193+ $titletext = $wgContLang->convert( $title->getPrefixedText() );
194194 $this->articles[] = $isRedirect
195195 ? '<span class="redirect-in-category">' . $this->getSkin()->makeKnownLinkObj( $title, $titletext ) . '</span>'
196196 : $this->getSkin()->makeSizeLinkObj( $pageLength, $title, $titletext );
Index: trunk/phase3/RELEASE-NOTES
@@ -112,6 +112,7 @@
113113 * Add 'change tagging' facility, where changes can be tagged internally with
114114 certain designations, which are displayed on various summaries of changes, and
115115 the entries can be styled with CSS.
 116+* (bug 17207) Fix regression breaking category page display on PHP 5.1
116117
117118 == API changes in 1.15 ==
118119 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Follow-up revisions

RevisionCommit summaryAuthorDate
r53780Follow up on r46020 and r46489. Improve the $wgContLang->convert() calling pr...philip15:54, 26 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46020Enable LanguageConverter on Category Pages.philip14:31, 22 January 2009

Status & tagging log