r78052 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78051‎ | r78052 | r78053 >
Date:07:42, 8 December 2010
Author:aaron
Status:ok
Tags:
Comment:
Tweak delete/insert query order to help with bug 26224
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevision.php
@@ -313,16 +313,17 @@
314314 # Update flagged revisions table
315315 $dbw->replace( 'flaggedrevs',
316316 array( array( 'fr_page_id', 'fr_rev_id' ) ), $revRow, __METHOD__ );
317 - # Clear out any previous garbage.
318 - # We want to be able to use this for tracking...
 317+ # Clear out any previous garbage...
319318 $dbw->delete( 'flaggedtemplates',
320319 array( 'ft_rev_id' => $this->getRevId() ), __METHOD__ );
321 - $dbw->delete( 'flaggedimages',
322 - array( 'fi_rev_id' => $this->getRevId() ), __METHOD__ );
323 - # Update our versioning params
 320+ # ...and insert template version data
324321 if ( $tmpInsertRows ) {
325322 $dbw->insert( 'flaggedtemplates', $tmpInsertRows, __METHOD__, 'IGNORE' );
326323 }
 324+ # Clear out any previous garbage...
 325+ $dbw->delete( 'flaggedimages',
 326+ array( 'fi_rev_id' => $this->getRevId() ), __METHOD__ );
 327+ # ...and insert file version data
327328 if ( $fileInsertRows ) {
328329 $dbw->insert( 'flaggedimages', $fileInsertRows, __METHOD__, 'IGNORE' );
329330 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r78053MFT r78052aaron07:48, 8 December 2010
r780961.17: Merge recent fixes tagged on CodeReview, except for problematic revisio...catrope21:17, 8 December 2010

Status & tagging log