r77949 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77948‎ | r77949 | r77950 >
Date:02:07, 7 December 2010
Author:demon
Status:ok
Tags:
Comment:
Followup r77883, rm the _ExternalHTTP stuff as well; cleans up IC msgs as well
Modified paths:
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -83,7 +83,6 @@
8484 '_CCDone' => false,
8585 '_Extensions' => array(),
8686 '_MemCachedServers' => '',
87 - '_ExternalHTTP' => false,
8887 '_LocalSettingsLocked' => true,
8988 '_UpgradeKey' => '',
9089 );
Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -35,8 +35,6 @@
3636 'config-your-language-help' => 'Select a language to use during the installation process.',
3737 'config-wiki-language' => 'Wiki language:',
3838 'config-wiki-language-help' => 'Select the language that the wiki will predominantly be written in.',
39 - 'config-allow-requests' => 'Allow external requests to MediaWiki.org',
40 - 'config-allow-requests-help' => 'If enabled, allow the installer to check MediaWiki.org to make sure you are installing the latest stable version',
4139 'config-back' => '← Back',
4240 'config-continue' => 'Continue →',
4341 'config-page-language' => 'Language',
@@ -423,13 +421,9 @@
424422 If you do not want a logo, leave this box blank.",
425423 'config-instantcommons' => 'Enable Instant Commons',
426424 'config-instantcommons-help' => '[http://www.mediawiki.org/wiki/InstantCommons Instant Commons] is a feature that allows wikis to use images, sounds and other media found on the [http://commons.wikimedia.org/ Wikimedia Commons] site.
427 -In order to do this, MediaWiki requires access to the Internet. $1
 425+In order to do this, MediaWiki requires access to the Internet.
428426
429 -For more information on this feature, including instructions on how to set it up for wikis other than the Wikimedia Commons, consult [http://mediawiki.org/wiki/Manual:$wgForeignFileRepos the manual].', // $1 is for indicating whether or not we should be able to use the feature
430 - 'config-instantcommons-good' => 'The installer was able to detect internet connectivity during the environment checks.
431 -You can enable this feature if you want to.',
432 - 'config-instantcommons-bad' => '\'\'Unfortunately, the installer was unable to detect internet connectivity during the environment checks, so you might be unable to use this feature.
433 -If your server is behind a proxy, you may need to do some [http://www.mediawiki.org/wiki/Manual:$wgHTTPProxy additional configuration].\'\'',
 427+For more information on this feature, including instructions on how to set it up for wikis other than the Wikimedia Commons, consult [http://mediawiki.org/wiki/Manual:$wgForeignFileRepos the manual].',
434428 'config-cc-error' => 'The Creative Commons license chooser gave no result.
435429 Enter the license name manually.',
436430 'config-cc-again' => 'Pick again...',
Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -201,7 +201,6 @@
202202 if ( isset( $languages[$contLang] ) ) {
203203 $this->setVar( 'wgLanguageCode', $contLang );
204204 }
205 - $this->setVar( '_ExternalHTTP', $r->getBool( 'config__ExternalHTTP' ) );
206205 return 'continue';
207206 }
208207 } elseif ( $this->parent->showSessionWarning ) {
@@ -222,14 +221,6 @@
223222 $s = Html::hidden( 'LanguageRequestTime', time() ) .
224223 $this->getLanguageSelector( 'UserLang', 'config-your-language', $userLang, $this->parent->getHelpBox( 'config-your-language-help' ) ) .
225224 $this->getLanguageSelector( 'ContLang', 'config-wiki-language', $contLang, $this->parent->getHelpBox( 'config-wiki-language-help' ) ) .
226 - $this->parent->getCheckBox(
227 - array(
228 - 'var' => '_ExternalHTTP',
229 - 'label' => 'config-allow-requests',
230 - 'help' => $this->parent->getHelpBox( 'config-allow-requests-help' )
231 - )
232 - );
233 -
234225 $this->addHTML( $s );
235226 $this->endForm();
236227 }
@@ -724,13 +715,11 @@
725716 'help' => $this->parent->getHelpBox( 'config-logo-help' )
726717 ) )
727718 );
728 - $canUse = $this->getVar( '_ExternalHTTP' ) ?
729 - 'config-instantcommons-good' : 'config-instantcommons-bad';
730719 $this->addHTML(
731720 $this->parent->getCheckBox( array(
732721 'var' => 'wgUseInstantCommons',
733722 'label' => 'config-instantcommons',
734 - 'help' => $this->parent->getHelpBox( 'config-instantcommons-help', wfMsgNoTrans( $canUse ) )
 723+ 'help' => $this->parent->getHelpBox( 'config-instantcommons-help' )
735724 ) ) .
736725 $this->getFieldSetEnd()
737726 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r77950Typofix r77949demon02:09, 7 December 2010
r77952Followup r77949, qqq message no longer relevantdemon02:22, 7 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77883Remove "checking for latest version" feature from the new installer. Original...demon15:32, 6 December 2010

Status & tagging log