r77928 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77927‎ | r77928 | r77929 >
Date:22:51, 6 December 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Some more unterminated statements (bug 26265)
Modified paths:
  • /trunk/extensions/WikiEditor/modules/contentCollector.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/ext.wikiEditor.addMediaWizard.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.iframe.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.templateEditor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.templateEditor.js
@@ -253,7 +253,7 @@
254254 $template.parent().attr('contentEditable', 'false');
255255 }
256256
257 - $template.click( function(event) {event.preventDefault(); return false;} )
 257+ $template.click( function(event) {event.preventDefault(); return false;}; )
258258
259259 $template.find( '.wikiEditor-template-name' )
260260 .click( function( event ) {
@@ -378,7 +378,7 @@
379379 .val( paramVal )
380380 .each( function() {
381381 $(this).css( 'height', $(this).val().length > 24 ? '4.5em' : '1.5em' );
382 - } )
 382+ } );
383383 $rows = $rows.not( $row );
384384 } else {
385385 // Create a new row
@@ -623,7 +623,7 @@
624624 */
625625 this.getAllInitialParams = function(){
626626 return params;
627 - }
 627+ };
628628 /**
629629 * Get original template text
630630 */
@@ -647,7 +647,7 @@
648648
649649 this.isCollapsible = function() {
650650 return collapsible;
651 - }
 651+ };
652652
653653 /**
654654 * Update ranges if there's been a change in one or more 'segments' of the template.
Index: trunk/extensions/WikiEditor/modules/contentCollector.js
@@ -431,7 +431,7 @@
432432 numLinesAfter : wrapData.numLinesAfter,
433433 lines : lineStrings
434434 };
435 - }
 435+ };
436436
437437 return cc;
438438 }
Index: trunk/extensions/WikiEditor/modules/ext.wikiEditor.addMediaWizard.js
@@ -12,4 +12,4 @@
1313 'http://prototype.wikimedia.org/s-2/js/mwEmbed/remotes/mediaWiki.js?&uselang=' + wgUserLanguage,
1414 'text/javascript'
1515 );
16 -}
\ No newline at end of file
 16+};
\ No newline at end of file
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.iframe.js
@@ -1140,7 +1140,7 @@
11411141 if ( preRange.compareEndPoints( "StartToEnd", preRange ) == 0 ) {
11421142 postFinished = true;
11431143 } else {
1144 - preRange.moveEnd( "character", -1 )
 1144+ preRange.moveEnd( "character", -1 );
11451145 if ( preRange.text == preText ) {
11461146 rawPreText += "\r\n";
11471147 } else {
@@ -1152,7 +1152,7 @@
11531153 if ( periRange.compareEndPoints( "StartToEnd", periRange ) == 0 ) {
11541154 periFinished = true;
11551155 } else {
1156 - periRange.moveEnd( "character", -1 )
 1156+ periRange.moveEnd( "character", -1 );
11571157 if ( periRange.text == periText ) {
11581158 rawPeriText += "\r\n";
11591159 } else {
@@ -1164,7 +1164,7 @@
11651165 if ( postRange.compareEndPoints("StartToEnd", postRange) == 0 ) {
11661166 postFinished = true;
11671167 } else {
1168 - postRange.moveEnd( "character", -1 )
 1168+ postRange.moveEnd( "character", -1 );
11691169 if ( postRange.text == postText ) {
11701170 rawPostText += "\r\n";
11711171 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r77932Wikibasha: bug 26265 - Missing ; from JSreedy23:32, 6 December 2010
r78088Fix syntax error from r77928reedy19:20, 8 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77872bug 26265, a few explicit ; at end of blocksreedy12:18, 6 December 2010
r77922(bug 26265) Many semicolons are missing from JavaScript files...reedy22:29, 6 December 2010
r77923(bug 26265) Many semicolons are missing from JavaScript files...reedy22:30, 6 December 2010
r77924(bug 26265) Many semicolons are missing from JavaScript files...reedy22:30, 6 December 2010
r77926(bug 26265) Many semicolons are missing from JavaScript files...reedy22:34, 6 December 2010

Comments

#Comment by Catrope (talk | contribs)   19:08, 8 December 2010
-		$template.click( function(event) {event.preventDefault(); return false;} )
+		$template.click( function(event) {event.preventDefault(); return false;}; )

That's a syntax error.

Status & tagging log