r77888 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77887‎ | r77888 | r77889 >
Date:16:17, 6 December 2010
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* (bug 26253) Removed $wgPostCommitUpdateList

As I said on the bug, this variable is not used since ages
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/database.txt (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/Setup.php (modified) (history)
  • /trunk/phase3/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/database.txt
@@ -146,9 +146,7 @@
147147 at the first query, and commits it before the output is sent. Locks will
148148 be held from the time when the query is done until the commit. So you
149149 can reduce lock time by doing as much processing as possible before you
150 -do your write queries. Update operations which do not require database
151 -access can be delayed until after the commit by adding an object to
152 -$wgPostCommitUpdateList.
 150+do your write queries.
153151
154152 Often this approach is not good enough, and it becomes necessary to
155153 enclose small groups of queries in their own transaction. Use the
Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2862,15 +2862,11 @@
28632863 * TODO: This could be in Wiki.php if that class made any sense at all
28642864 */
28652865 function wfDoUpdates() {
2866 - global $wgPostCommitUpdateList, $wgDeferredUpdateList;
 2866+ global $wgDeferredUpdateList;
28672867 foreach ( $wgDeferredUpdateList as $update ) {
28682868 $update->doUpdate();
28692869 }
2870 - foreach ( $wgPostCommitUpdateList as $update ) {
2871 - $update->doUpdate();
2872 - }
28732870 $wgDeferredUpdateList = array();
2874 - $wgPostCommitUpdateList = array();
28752871 }
28762872
28772873 /**
Index: trunk/phase3/includes/Setup.php
@@ -379,7 +379,6 @@
380380 wfProfileIn( $fname.'-misc2' );
381381
382382 $wgDeferredUpdateList = array();
383 -$wgPostCommitUpdateList = array();
384383
385384 if ( $wgAjaxUploadDestCheck ) $wgAjaxExportList[] = 'SpecialUpload::ajaxGetExistsWarning';
386385
Index: trunk/phase3/index.php
@@ -115,8 +115,5 @@
116116 $mediaWiki->performRequestForTitle( $wgTitle, $wgArticle, $wgOut, $wgUser, $wgRequest );
117117 $mediaWiki->finalCleanup( $wgDeferredUpdateList, $wgOut );
118118
119 -# Not sure when $wgPostCommitUpdateList gets set, so I keep this separate from finalCleanup
120 -$mediaWiki->doUpdates( $wgPostCommitUpdateList );
121 -
122119 $mediaWiki->restInPeace();
123120
Index: trunk/phase3/RELEASE-NOTES
@@ -96,6 +96,7 @@
9797 of LocalSettings.php, in LocalSettings.php itself. Instead, this is done
9898 automatically if $wgInvalidateCacheOnLocalSettingsChange is true (which is
9999 the default).
 100+* (bug 26253) $wgPostCommitUpdateList has been removed
100101
101102 === New features in 1.17 ===
102103 * (bug 10183) Users can now add personal styles and scripts to all skins via

Comments

#Comment by Catrope (talk | contribs)   16:58, 8 December 2010

There's two usages left in extensions/WebDAV

#Comment by IAlex (talk | contribs)   17:12, 8 December 2010

I know, it's an ancient, commented out, copy of index.php (still including $wgLoadBalancer).

#Comment by Catrope (talk | contribs)   18:37, 8 December 2010

Right, sorry about that. Marking OK.

Status & tagging log