r77802 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77801‎ | r77802 | r77803 >
Date:15:05, 5 December 2010
Author:platonides
Status:deferred
Tags:
Comment:
Fix PHP Deprecated: Call-time pass-by-reference has been deprecated in ./tools/commonsapi/commonsapi.php on line 136
but leave the other 6 to test if this can be committed or not.
Modified paths:
  • /trunk/tools/commonsapi/commonsapi.php (modified) (history)

Diff [purge]

Index: trunk/tools/commonsapi/commonsapi.php
@@ -133,7 +133,7 @@
134134 function try_information_template ( $text ) {
135135 global $titles ;
136136 $matches = array () ;
137 - preg_match_all ( '/span\s+id="field-[^"]+"/' , $text , &$matches ) ;
 137+ preg_match_all ( '/span\s+id="field-[^"]+"/' , $text , $matches ) ;
138138 $matches = $matches[0] ;
139139 if ( count ( $matches ) == 0 ) return false ;
140140
@@ -532,4 +532,4 @@
533533
534534 print '</response>' ;
535535
536 -?>
\ No newline at end of file
 536+?>

Follow-up revisions

RevisionCommit summaryAuthorDate
r77803Follow up r77802...platonides15:06, 5 December 2010

Status & tagging log