r77796 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77795‎ | r77796 | r77797 >
Date:11:16, 5 December 2010
Author:dantman
Status:resolved (Comments)
Tags:
Comment:
Followup r77793, documentation for icon as a string was missing.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -2268,11 +2268,16 @@
22692269 * a new block. Though note that you may need to add some custom css to get good styling
22702270 * of new blocks in monobook. vector and modern should work without any special css.
22712271 *
2272 - * $wgFooterIcons itself is a key/value array. The key being the name of a block that
2273 - * icons will be wrapped in. The final id varries by skin.
2274 - * The value being a key/value array of icons. The key may or may not be used by the
 2272+ * $wgFooterIcons itself is a key/value array.
 2273+ * The key os the name of a block that the icons will be wrapped in.
 2274+ * The final id varries by skin; Monobook and Vector will turn poweredby into f-poweredbyico
 2275+ * while Modern turns it into mw_poweredby.
 2276+ * The value is a key/value array of icons. The key may or may not be used by the
22752277 * skin but it can be used to find the icon and unset it or change the icon if needed.
2276 - * The innermost array has the following keys:
 2278+ * This is useful for disabling icons that are set by extensions.
 2279+ * The value should be either a string or an array.
 2280+ * If it is a string it will be output directly, however some skins may choose to ignore it.
 2281+ * An array is the preferred format for the icon, the following keys are used:
22772282 * src: An absolute url to the image to use for the icon, this is recommended
22782283 * but not required, however some skins will ignore icons without an image
22792284 * url: The url to use in the <a> arround the text or icon, if not set an <a> will not be outputted

Follow-up revisions

RevisionCommit summaryAuthorDate
r78424Follow-up r77796: a couple of typos in the comment, and break more consistent...happy-melon01:03, 15 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77793Folowup r77763, add documentation for $wgFooterIcons.dantman10:58, 5 December 2010

Comments

#Comment by Happy-melon (talk | contribs)   01:04, 15 December 2010

Couple of typos here, fixed in r78424.

Status & tagging log