r77786 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77785‎ | r77786 | r77787 >
Date:10:11, 5 December 2010
Author:reedy
Status:ok
Tags:
Comment:
So long, verified!

bug 26245 Drop "verified" status
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/codereview.pg.sql (modified) (history)
  • /trunk/extensions/CodeReview/codereview.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/codereview.pg.sql
@@ -14,7 +14,7 @@
1515
1616 CREATE INDEX code_repo_repo_name ON code_repo (repo_name);
1717
18 -CREATE TYPE cr_cr_status AS ENUM ('new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred');
 18+CREATE TYPE cr_cr_status AS ENUM ('new', 'fixme', 'reverted', 'resolved', 'ok', 'deferred');
1919 CREATE TABLE code_rev (
2020 cr_repo_id INTEGER NOT NULL,
2121
Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -98,8 +98,6 @@
9999 'code-status-desc-resolved' => 'Revision had an issue which was addressed by a later revision.',
100100 'code-status-ok' => 'ok',
101101 'code-status-desc-ok' => 'Revision fully reviewed and reviewer is sure it is fine in every way.',
102 - 'code-status-verified' => 'verified',
103 - 'code-status-desc-verified' => 'Revision has been tested and is working as intended.',
104102 'code-status-deferred' => 'deferred',
105103 'code-status-desc-deferred' => 'Revision does not require review.',
106104 'code-status-old' => 'old',
Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -142,7 +142,7 @@
143143 * @return Array
144144 */
145145 public static function getPossibleStates() {
146 - return array( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred', 'old' );
 146+ return array( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'deferred', 'old' );
147147 }
148148
149149 /**
Index: trunk/extensions/CodeReview/codereview.sql
@@ -51,7 +51,6 @@
5252 -- 'reverted': Was completely reverted by a later revision
5353 -- 'resolved': Issues with this rev have been since resolved
5454 -- 'ok': Reviewed, no issues spotted
55 - -- 'verified': Reviewed and tested, no issues spotted
5655 -- 'deferred': Not reviewed at this time (usually non-Wikimedia extension)
5756 -- 'old': Predates the extension/doesn't require review
5857 -- See CodeRevision::getPossibleStates() (in backend/CodeRevision.php) for most up to date list

Follow-up revisions

RevisionCommit summaryAuthorDate
r77788Minor followup to r77786, drop verified status from bulkStatusUpdate.php tooreedy10:15, 5 December 2010

Status & tagging log