r77726 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77725‎ | r77726 | r77727 >
Date:17:00, 4 December 2010
Author:dantman
Status:ok
Tags:
Comment:
Follow up r77718, fix broken inconsistent use of $fname/$name in getCommonStylePath and getSkinStylePath.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -2036,14 +2036,14 @@
20372037 }
20382038 }
20392039
2040 - function getCommonStylePath( $fname ) {
 2040+ function getCommonStylePath( $fame ) {
20412041 global $wgStylePath, $wgStyleVersion;
20422042 return "{$wgStylePath}/common/$name?$wgStyleVersion";
20432043 }
20442044
2045 - function getSkinStylePath( $fname ) {
 2045+ function getSkinStylePath( $name ) {
20462046 global $wgStylePath, $wgStyleVersion;
2047 - return "{$wgStylePath}/{$this->stylename}/$fname?$wgStyleVersion";
 2047+ return "{$wgStylePath}/{$this->stylename}/$name?$wgStyleVersion";
20482048 }
20492049
20502050 /* these are used extensively in SkinTemplate, but also some other places */

Follow-up revisions

RevisionCommit summaryAuthorDate
r77728Fixme fixme... typo typo... fix r77726's broken fix.dantman17:10, 4 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77718Implement getSkinStylePath and getCommonStylePath for image paths used direct...dantman14:45, 4 December 2010

Status & tagging log