r77666 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77665‎ | r77666 | r77667 >
Date:16:24, 3 December 2010
Author:reedy
Status:ok
Tags:
Comment:
* (bug 26219) Show API limits for multi values in description

Also move bug 9675/r77612 RELEASE-NOTES to the correct section
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiBase.php (modified) (history)
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -1329,7 +1329,7 @@
13301330 * Makes an encoded list of strings from an array
13311331 * $mode:
13321332 * LIST_COMMA - comma separated, no field names
1333 - * LIST_AND - ANDed WHERE clause (without the WHERE)
 1333+ * LIST_ANDLIST_AND - ANDed WHERE clause (without the WHERE)
13341334 * LIST_OR - ORed WHERE clause (without the WHERE)
13351335 * LIST_SET - comma separated with field names, like a SET clause
13361336 * LIST_NAMES - comma separated field names
Index: trunk/phase3/includes/api/ApiBase.php
@@ -366,10 +366,17 @@
367367 }
368368 break;
369369 }
 370+
 371+ if ( isset( $paramSettings[self::PARAM_ISMULTI] ) ) {
 372+ $desc .= $paramPrefix . "Maximum number of values " .
 373+ self::LIMIT_SML1 . " (" . self::LIMIT_SML2 . " for bots)";
 374+ }
370375 }
371376 }
372377
373 - $default = is_array( $paramSettings ) ? ( isset( $paramSettings[self::PARAM_DFLT] ) ? $paramSettings[self::PARAM_DFLT] : null ) : $paramSettings;
 378+ $default = is_array( $paramSettings )
 379+ ? ( isset( $paramSettings[self::PARAM_DFLT] ) ? $paramSettings[self::PARAM_DFLT] : null )
 380+ : $paramSettings;
374381 if ( !is_null( $default ) && $default !== false ) {
375382 $desc .= $paramPrefix . "Default: $default";
376383 }
Index: trunk/phase3/RELEASE-NOTES
@@ -443,6 +443,8 @@
444444 case.
445445 * (bug 26164) Potential html injection when the database server isn't available
446446 * (bug 26160) Upload description set by extensions are not propagated
 447+* (bug 9675) generateSitemap.php now takes an --urlpath parameter to allow
 448+ absolute URLs in the sitemap index (as required e.g. by Google)
447449
448450 === API changes in 1.17 ===
449451 * (bug 22738) Allow filtering by action type on query=logevent.
@@ -543,8 +545,7 @@
544546 * (bug 26125) prop=imageinfo&iiprop=size now returns the page count if the
545547 file is a multi-page file
546548 * (bug 10268) Added linktodiffs parameter on action=feedwatchlist
547 -* (bug 9675) generateSitemap.php now takes an --urlpath parameter to allow
548 - absolute URLs in the sitemap index (as required e.g. by Google)
 549+* (bug 26219) Show API limits for multi values in description
549550
550551 === Languages updated in 1.17 ===
551552

Follow-up revisions

RevisionCommit summaryAuthorDate
r77692Followup r77666, remove changed in database comment (no idea where that came ...reedy23:50, 3 December 2010
r77697Followup r77666, bug 26219...reedy00:36, 4 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77176bug 9675: sitemap-index doesn't include full location pathvyznev19:26, 23 November 2010
r77612followup to r77176: code style, release notesvyznev22:40, 2 December 2010

Status & tagging log