r77557 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77556‎ | r77557 | r77558 >
Date:04:42, 2 December 2010
Author:werdna
Status:deferred (Comments)
Tags:
Comment:
Merge r77555 into core. As a bonus, fix the PHP notices that HTMLForm has been spewing on 1.16wmf4 for a few months
Modified paths:
  • /branches/wmf/1.16wmf4 (modified) (history)
  • /branches/wmf/1.16wmf4/StartProfiler.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/AbuseFilter (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ArticleAssessmentPilot (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CategoryTree (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CentralAuth (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CentralAuth/CentralAuthUser.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CentralNotice (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CodeReview (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/Collection (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CommunityApplications (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CommunityHiring (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ConditionalShowSection (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ContactPage (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ContactPageFundraiser (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ContributionReporting (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ContributionTracking (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ExtensionDistributor (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/FlaggedRevs (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/FlaggedRevs/language (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/FundraiserPortal (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/GlobalBlocking (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/GlobalUsage (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/HoneypotIntegration/HoneypotIntegration.class.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ImageMap/desc-20.png (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ImageMap/desc.svg (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/InputBox (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/LandingCheck (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/LiquidThreads (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/LiquidThreads/i18n (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/LiquidThreads/i18n/Lqt.namespaces.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/LiquidThreads_alpha (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/LiquidThreads_alpha/i18n (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/LiquidThreads_alpha/i18n/Lqt.namespaces.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/LocalisationUpdate (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/NewUserMessage/NewUserMessage.class.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/OggHandler (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/PagedTiffHandler (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/PdfHandler (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ProofreadPage (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/RSS (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/ballots/Ballot.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/crypt/Crypt.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/crypt/Random.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/entities/Election.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/entities/Entity.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/entities/Option.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/entities/Question.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/main/Base.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/main/Context.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/main/Store.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/DetailsPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/DumpPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/EntryPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/ListPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/LoginPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/MessageDumpPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/Page.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/TallyPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/TranslatePage.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/pages/VotePage.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/talliers/ElectionTallier.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/talliers/Tallier.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/user/Auth.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/SecurePoll/includes/user/Voter.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/StrategyWiki (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/StringFunctionsEscaped (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/TorBlock/TorBlock.class.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/TrustedXFF (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/TrustedXFF/trusted-hosts.txt (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UploadWizard (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UploadWizard/resources/mw.LanguageUpWiz.js (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/OptIn (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/PrefSwitch (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Modules/SimpleSearch/SimpleSearch.js (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/js/plugins/jquery.cookie.js (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/js/plugins/jquery.textSelection.js (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/VariablePage (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/WikimediaMessages (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/WikimediaMessages/WikimediaLicenseTexts.i18n.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/WikimediaMobile (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/normal/Makefile (modified) (history)
  • /branches/wmf/1.16wmf4/includes (modified) (history)
  • /branches/wmf/1.16wmf4/includes/Article.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/AutoLoader.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/ChangesList.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/ConfEditor.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/DefaultSettings.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/EditPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/HTMLForm.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/HistoryPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/Html.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/HttpFunctions.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/LocalisationCache.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/LogEventsList.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/Math.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/MessageCache.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/OutputPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/Preferences.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/Sanitizer.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/SpecialPage.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/UserMailer.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/UserRightsProxy.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/WebRequest.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/api (modified) (history)
  • /branches/wmf/1.16wmf4/includes/api/ApiBase.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/api/ApiLogin.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/api/ApiQueryAllUsers.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/api/ApiQueryUsers.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/api/ApiUpload.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/diff (modified) (history)
  • /branches/wmf/1.16wmf4/includes/diff/DifferenceInterface.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/filerepo (modified) (history)
  • /branches/wmf/1.16wmf4/includes/filerepo/File.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/json/Services_JSON.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/media (modified) (history)
  • /branches/wmf/1.16wmf4/includes/media/Bitmap.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/parser (modified) (history)
  • /branches/wmf/1.16wmf4/includes/specials (modified) (history)
  • /branches/wmf/1.16wmf4/includes/specials/SpecialAllmessages.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/specials/SpecialDisableAccount.php (added) (history)
  • /branches/wmf/1.16wmf4/includes/specials/SpecialRevisiondelete.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/specials/SpecialUpload.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/specials/SpecialUploadStash.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/specials/SpecialUserlogin.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/upload (modified) (history)
  • /branches/wmf/1.16wmf4/includes/upload/UploadBase.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/upload/UploadFromFile.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/upload/UploadStash.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages (modified) (history)
  • /branches/wmf/1.16wmf4/languages/Language.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/Names.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesAce.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesAry.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesBh.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesBjn.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesCkb_arab.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesEn.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesKbd.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesKbd_cyrl.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesLad.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesMin.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesNl_informal.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesTt_cyrl.php (modified) (history)
  • /branches/wmf/1.16wmf4/languages/messages/MessagesUg.php (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/Maintenance.php (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/addwiki.php (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/cleanupTable.inc (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/deleteSelfExternals.php (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/dumpTextPass.php (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/fetchText.php (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/jobs-loop.sh (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/moveBatch.php (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/storage/make-all-blobs (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/storage/recompressTracked.sh (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/storage/testRctComplete.php (modified) (history)
  • /branches/wmf/1.16wmf4/math/GNUmakefile (modified) (history)
  • /branches/wmf/1.16wmf4/skins (modified) (history)
  • /branches/wmf/1.16wmf4/skins/Vector.php (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common/images (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common/preview.js (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common/shared.css (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common/wikibits.js (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r77621Merge DisableAccount changes since r77557 to prepare for deploymentwerdna00:13, 3 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77555Merge DisableAccount extension into core, disabled by default because the rig...werdna04:17, 2 December 2010

Comments

#Comment by 😂 (talk | contribs)   22:32, 30 December 2010

Please don't merge all the stupid prop changes for paths unrelated to your merge. I know svn likes to add them, but it makes it annoying to review.

#Comment by Catrope (talk | contribs)   22:43, 30 December 2010
$ cat /home/catrope/bin/svnsucks
#! /bin/bash
svn st | grep '^ M' | awk '{print $2}' | xargs svn revert

$

Status & tagging log