r77508 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77507‎ | r77508 | r77509 >
Date:20:57, 30 November 2010
Author:btongminh
Status:ok
Tags:
Comment:
(bug 26160) Upload description set by extensions are not propagated

Regression originating from the UploadForm rewrite; going to mark for 1.16
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -79,6 +79,7 @@
8080 * Brent G
8181 * Brianna Laugher
8282 * Carlin
 83+* Carsten Nielsen
8384 * Conrad Irwin
8485 * Dan Barrett
8586 * Dan Nessett
Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -246,6 +246,7 @@
247247 'hideignorewarning' => $hideIgnoreWarning,
248248 'destwarningack' => (bool)$this->mDestWarningAck,
249249
 250+ 'description' => $this->mComment,
250251 'texttop' => $this->uploadFormTextTop,
251252 'textaftersummary' => $this->uploadFormTextAfterSummary,
252253 'destfile' => $this->mDesiredDestName,
@@ -740,6 +741,7 @@
741742 protected $mDestWarningAck;
742743 protected $mDestFile;
743744
 745+ protected $mComment;
744746 protected $mTextTop;
745747 protected $mTextAfterSummary;
746748
@@ -754,6 +756,9 @@
755757 $this->mDestWarningAck = !empty( $options['destwarningack'] );
756758 $this->mDestFile = isset( $options['destfile'] ) ? $options['destfile'] : '';
757759
 760+ $this->mComment = isset( $options['description'] ) ?
 761+ $options['description'] : '';
 762+
758763 $this->mTextTop = isset( $options['texttop'] )
759764 ? $options['texttop'] : '';
760765
@@ -930,6 +935,7 @@
931936 'label-message' => $this->mForReUpload
932937 ? 'filereuploadsummary'
933938 : 'fileuploadsummary',
 939+ 'default' => $this->mComment,
934940 'cols' => intval( $wgUser->getOption( 'cols' ) ),
935941 'rows' => 8,
936942 )
Index: trunk/phase3/RELEASE-NOTES
@@ -442,6 +442,7 @@
443443 * Show "skin does not exist error" only when the skin is inputted in the wrong
444444 case.
445445 * (bug 26164) Potential html injection when the database server isn't available
 446+* (bug 26160) Upload description set by extensions are not propagated
446447
447448 === API changes in 1.17 ===
448449 * (bug 22738) Allow filtering by action type on query=logevent.

Status & tagging log