r77509 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77508‎ | r77509 | r77510 >
Date:20:59, 30 November 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r77403 - added forgotten globals
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Concept.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Declare.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_SetRecurringEvent.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Show.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Concept.php
@@ -23,7 +23,7 @@
2424 * @param Parser $parser
2525 */
2626 public static function render( Parser &$parser ) {
27 - global $smwgQDefaultNamespaces, $smwgQMaxSize, $smwgQMaxDepth, $wgContLang;
 27+ global $smwgQDefaultNamespaces, $smwgQMaxSize, $smwgQMaxDepth, $wgContLang, $wgTitle;
2828
2929 smwfLoadExtensionMessages( 'SemanticMediaWiki' );
3030
Index: trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_SetRecurringEvent.php
@@ -41,6 +41,7 @@
4242 }
4343
4444 // Starting from MW 1.16, there is a more suited method available: Title::isSpecialPage
 45+ global $wgTitle;
4546 if ( $wgTitle->getNamespace() == NS_SPECIAL ) {
4647 global $wgOut;
4748 SMWOutputs::commitToOutputPage( $wgOut );
Index: trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Declare.php
@@ -75,6 +75,7 @@
7676 }
7777
7878 // Starting from MW 1.16, there is a more suited method available: Title::isSpecialPage
 79+ global $wgTitle;
7980 if ( $wgTitle->getNamespace() == NS_SPECIAL ) {
8081 global $wgOut;
8182 SMWOutputs::commitToOutputPage( $wgOut );
Index: trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Show.php
@@ -23,7 +23,7 @@
2424 * @param Parser $parser
2525 */
2626 public static function render( Parser &$parser ) {
27 - global $smwgQEnabled, $smwgIQRunningNumber;
 27+ global $smwgQEnabled, $smwgIQRunningNumber, $wgTitle;
2828
2929 if ( $smwgQEnabled ) {
3030 $smwgIQRunningNumber++;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77403Follow up to r77402 - applying similar change to the other parser hooks. Alth...jeroendedauw22:26, 28 November 2010

Status & tagging log