r77351 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77350‎ | r77351 | r77352 >
Date:12:58, 27 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Switch "Notes" to "Comments" in code-field-comments

No idea why it's "notes" for CodeRevisionListView, and "comments" everywhere else
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -54,7 +54,7 @@
5555 'code-field-status' => 'Status',
5656 'code-field-status-description' => 'Status description',
5757 'code-field-timestamp' => 'Date',
58 - 'code-field-comments' => 'Notes',
 58+ 'code-field-comments' => 'Comments',
5959 'code-field-path' => 'Path',
6060 'code-field-text' => 'Note',
6161 'code-field-select' => 'Select',
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -79,7 +79,7 @@
8080 $dbr = wfGetDB( DB_SLAVE );
8181 $revObjects = array();
8282 $res = $dbr->select( 'code_rev', '*', array( 'cr_id' => $revisions, 'cr_repo_id' => $this->mRepo->getId() ), __METHOD__ );
83 - foreach ($res as $row ) {
 83+ foreach ( $res as $row ) {
8484 $revObjects[] = CodeRevision::newFromRow( $this->mRepo, $row );
8585 }
8686

Status & tagging log