r77350 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77349‎ | r77350 | r77351 >
Date:12:11, 27 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Use CodeRevision::isValidStatus rather than latching onto one of the array objects as the code is more readable
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -94,7 +94,7 @@
9595 }
9696
9797 if ( $wgUser->isAllowed( 'codereview-set-status' ) &&
98 - $revObjects && $revObjects[0]->isValidStatus( $status ) ) {
 98+ $revObjects && CodeRevision::isValidStatus( $status ) ) {
9999 foreach ( $revObjects as $rev ) {
100100 $rev->setStatus( $status, $wgUser );
101101 }

Status & tagging log