r77322 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r77321‎ | r77322 | r77323 >
Date:07:53, 26 November 2010
Author:philip
Status:ok (Comments)
Tags:
Comment:
Follow up r77321. Replace EditPage::spamPage to $editPage->spamPageWithContent in wfSpamBlacklistFilterMerged.

I did nothing to wfSpamBlacklistFilter which seems has been replaced by wfSpamBlacklistFilterMerged.
Modified paths:
  • /trunk/extensions/SpamBlacklist/SpamBlacklist.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SpamBlacklist/SpamBlacklist.php
——@@ -85,7 +85,7 @@
8686 $title = $editPage->mArticle->getTitle();
8787 $ret = $spamObj->filter( $title, $text, '', $editSummary, $editPage );
8888 if ( $ret !== false ){
89 - $editPage->spamPage( $ret );
 89+ $editPage->spamPageWithContent( $ret );
9090 }
9191 // Return convention for hooks is the inverse of $wgFilterCallback
9292 return ( $ret === false );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77321Add a new method 'spamPageWithContent' to class EditPage. User can be allowed...philip07:48, 26 November 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   04:36, 12 January 2011

What about the SimpleAntiSpam's and SpamRegex's and CreateRedirect's use of spamPage() ??

#Comment by PhiLiP (talk | contribs)   08:28, 12 January 2011

The spamPage() is kept for compatibility so it would not generate any error.

#Comment by MarkAHershberger (talk | contribs)   17:20, 12 January 2011

Asking Reedy to look at this since he touched wfSpamBlacklistFilter() not too long ago.

Status & tagging log