r77320 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77319‎ | r77320 | r77321 >
Date:07:45, 26 November 2010
Author:hashar
Status:ok (Comments)
Tags:
Comment:
doc comments: fix grammar and return parameter. fu r77296
Modified paths:
  • /trunk/phase3/includes/BagOStuff.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/BagOStuff.php
@@ -131,7 +131,9 @@
132132 }
133133
134134 /**
135 - * @return null if lock is not possible. New value incremented by 1
 135+ * @param $key String: Key yo increase
 136+ * @param $value Integer: Value to add to $key (Default 1)
 137+ * @return null if lock is not possible else $key value increased by $value
136138 */
137139 public function incr( $key, $value = 1 ) {
138140 if ( !$this->lock( $key ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r77676typo (fu r77320)hashar19:56, 3 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77296consistent incr() return value in case of error. follow up 74579hashar19:47, 25 November 2010

Comments

#Comment by Nikerabbit (talk | contribs)   07:58, 26 November 2010

Still one typo "Key yo increase" :)

#Comment by Hashar (talk | contribs)   19:56, 3 December 2010

typo fixed!

Status & tagging log