r77311 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77310‎ | r77311 | r77312 >
Date:23:41, 25 November 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r77302, update ApiRevisionUpdate to give flag removal
Modified paths:
  • /trunk/extensions/CodeReview/api/ApiRevisionUpdate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/api/ApiRevisionUpdate.php
@@ -49,7 +49,8 @@
5050 $params['status'],
5151 $params['addtags'],
5252 $params['removetags'],
53 - $params['flags'],
 53+ $params['addflags'],
 54+ $params['removeflags'],
5455 $params['comment']
5556 );
5657
@@ -93,10 +94,15 @@
9495 ApiBase::PARAM_TYPE => 'string',
9596 ApiBase::PARAM_ISMULTI => true,
9697 ),
97 - 'flags' => array(
 98+ 'addflags' => array(
9899 ApiBase::PARAM_TYPE => 'string',
99100 ApiBase::PARAM_ISMULTI => true,
100101 ApiBase::PARAM_TYPE => CodeRevision::getPossibleFlags()
 102+ ),
 103+ 'removeflags' => array(
 104+ ApiBase::PARAM_TYPE => 'string',
 105+ ApiBase::PARAM_ISMULTI => true,
 106+ ApiBase::PARAM_TYPE => CodeRevision::getPossibleFlags()
101107 )
102108 );
103109 }
@@ -109,7 +115,8 @@
110116 'status' => 'Status to set the revision to',
111117 'addtags' => 'Tags to be added to the revision',
112118 'removetags' => 'Tags to be removed from the revision',
113 - 'flags' => 'Code Signoff flags to assign to the revision by the current user',
 119+ 'addflags' => 'Code Signoff flags to assign to the revision by the current user',
 120+ 'removeflags' => 'Code Signoff flags to strike from the revision by the current user',
114121 );
115122 }
116123

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77302(bug 26014) Allow users to strike their own sign-offs. Implemented with a tim...catrope21:39, 25 November 2010

Comments

#Comment by Catrope (talk | contribs)   10:23, 26 November 2010

Really a followup to r76930.

#Comment by Reedy (talk | contribs)   12:01, 26 November 2010

Well, it worked fine in that revision :P

#Comment by Catrope (talk | contribs)   12:03, 26 November 2010

Ah, yes, because I changed a function and forgot to update the API caller. Got it.

#Comment by Reedy (talk | contribs)   12:14, 26 November 2010

Heh, yup :)

Status & tagging log