r77178 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r77177‎ | r77178 | r77179 >
Date:19:57, 23 November 2010
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
testRegisteringNullModuleThrowsAnException - $this->markTestIncomplete( "Broken by r77011" );

Just to shut codurr up
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/ResourceLoaderTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/ResourceLoaderTest.php
——@@ -57,6 +57,7 @@
5858 * @expectedException MWException
5959 */
6060 public function testRegisteringNullModuleThrowsAnException( ResourceLoader $resourceLoader ) {
 61+ $this->markTestIncomplete( "Broken by r77011" );
6162 $resourceLoader->register( 'TEST.nullModule', null );
6263 }
6364 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r77179Merging from r77174 thru r77178 of trunkawjrichards20:05, 23 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77011* Made Resources.php return a pure-data array instead of an ugly mix of data ...tstarling10:41, 19 November 2010

Comments

#Comment by Hashar (talk | contribs)   07:26, 24 November 2010

?!! Fix the test!

#Comment by Reedy (talk | contribs)   10:28, 24 November 2010

I've no idea if the test is broken, or it's Tims refactoring of the RL. I don't know enough about the RL to fix this, and codurr was annoying me (and others) by pinging...

#Comment by Catrope (talk | contribs)   15:35, 3 December 2010

This test broke because Tim didn't update it when he changed the RL interface in his refactoring. Tim's refactoring isn't broken AFAICT and this test isn't really broken either, just out of date.

#Comment by Reedy (talk | contribs)   17:36, 30 December 2010

Marking reverted per r79254

Status & tagging log