r77123 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r77122‎ | r77123 | r77124 >
Date:00:04, 23 November 2010
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Pressing enter in an input field doesn't trigger display:none elements in WebKit-browsers. Either put Back-button after Continue (visually not a good choise)... or keep the current double-button-first-hidden approach but in a different way that doesn't use display:none. Doing the latter for now.
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerPage.php
——@@ -60,7 +60,7 @@
6161 if ( $continue ) {
6262 // Fake submit button for enter keypress
6363 $s .= Xml::submitButton( wfMsg( "config-$continue" ),
64 - array( 'name' => "enter-$continue", 'style' => 'display:none' ) ) . "\n";
 64+ array( 'name' => "enter-$continue", 'style' => 'visibility:hidden;overflow:hidden;width:1px;margin:0' ) ) . "\n";
6565 }
6666
6767 if ( $id !== 0 ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r77874Adding reference to bug 26267. Follow-up on r77123krinkle13:21, 6 December 2010

Comments

#Comment by Catrope (talk | contribs)   14:58, 3 December 2010

Should add a comment explaining this strange choice of style.

#Comment by Krinkle (talk | contribs)   13:22, 6 December 2010

I've filed bug 26267. And added it to the comments in r77874

Status & tagging log