r77111 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r77110‎ | r77111 | r77112 >
Date:19:16, 22 November 2010
Author:hashar
Status:reverted (Comments)
Tags:
Comment:
unconditionally send email to comment author

This is a prerequisite to implement support for In-Reply-To header. This
header let your mail agent thread the messages by conversation. To follow
the conversations, it helps to receive our own emails.

See comments on r74967 and RFC 2822 section 3.6.4:
http://tools.ietf.org/html/rfc2822#section-3.6.4
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
——@@ -373,14 +373,6 @@
374374
375375 //Notify commenters and revision author of followup revision
376376 foreach ( $users as $user ) {
377 - // Notify user with its own message if he already want
378 - // to be CCed of all emails it sends.
379 - if ( $commitAuthorId == $user->getId() ) {
380 - if(! $user->getBoolOption( 'ccmeonemails' ) ) {
381 - continue;
382 - }
383 - }
384 -
385377 if ( $user->canReceiveEmail() ) {
386378 // Send message in receiver's language
387379 $lang = array( 'language' => $user->getOption( 'language' ) );
——@@ -473,14 +465,6 @@
474466 }
475467
476468 foreach ( $users as $user ) {
477 - // Notify user with its own message if he already want
478 - // to be CCed of all emails it sends.
479 - if ( $wgUser->getId() == $user->getId() ) {
480 - if(! $user->getBoolOption( 'ccmeonemails' ) ) {
481 - continue;
482 - }
483 - }
484 -
485469 if ( $user->canReceiveEmail() ) {
486470 // Send message in receiver's language
487471 $lang = array( 'language' => $user->getOption( 'language' ) );

Sign-offs

UserFlagDate
Hasharinspected21:25, 4 March 2011
Hashartested21:25, 4 March 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r83182Revert r77111 due to many people not liking the behaviour....reedy23:54, 3 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74967* Let user receives its own comments by emails if already wants...hashar20:50, 18 October 2010

Comments

#Comment by 😂 (talk | contribs)   14:56, 27 December 2010

I'm not sure I like this...I know when I've made a comment, I don't want an e-mail about it too.

#Comment by Hashar (talk | contribs)   15:40, 27 December 2010

Maybe I should handle this by adding yet another user preference. The aim was to implement in-reply-to header to threads messages in our MUAs.

#Comment by 😂 (talk | contribs)   15:42, 27 December 2010

Prefs are evil, but less evil than spam ;-)

#Comment by Nikerabbit (talk | contribs)   15:44, 16 February 2011

This doesn't work for my workflow either. I just use the emails as notifications. If the comment is interesting, I open the revision page. Either way I delete the message right after and I don't care how it is grouped or not.

#Comment by Siebrand (talk | contribs)   22:59, 3 March 2011

Please revert. This is just plain spamming ourselves.

#Comment by Hashar (talk | contribs)   07:56, 4 March 2011

Sorry, haven't seen Nikerabbit mail or I would have reverted it earlier.

Status & tagging log