r77096 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r77095‎ \| r77096 \| r77097 >
Date:	04:17, 22 November 2010
Author:	brion
Status:	ok (Comments)
Tags:
Comment:	SVGEdit extension initial checkin: on-web editing of uploaded SVG files using svg-edit Includes svg-edit 2.5.1: * added MediaWiki extension in its extensions dir with our customizations * removed stock server-assisted local file load/save extension from same dir to avoid having stray .php files Briefly tested on Firefox 3.6, 4b7, and Chrome 8 beta. IE compat may be possible with Flash tools, but not a big deal. Needs more visual cleanup, permissions checks, etc. Currently requires ApiSVGProxy extension in order to load initial SVG file data!
Modified paths:	/trunk/extensions/SVGEdit (added) (history) /trunk/extensions/SVGEdit/SVGEdit.hooks.php (added) (history) /trunk/extensions/SVGEdit/SVGEdit.i18n.php (added) (history) /trunk/extensions/SVGEdit/SVGEdit.php (added) (history) /trunk/extensions/SVGEdit/modules (added) (history) /trunk/extensions/SVGEdit/modules/ext.svgedit.editButton.js (added) (history) /trunk/extensions/SVGEdit/svg-edit (added) (history) /trunk/extensions/SVGEdit/svg-edit/canvg (added) (history) /trunk/extensions/SVGEdit/svg-edit/canvg/canvg.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/canvg/rgbcolor.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/embedapi.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/closepath_icons.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/ext-arrows.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/ext-closepath.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/ext-connector.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/ext-eyedropper.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/ext-foreignobject.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/ext-helloworld.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/ext-markers.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/ext-mediawiki.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/eyedropper-icon.xml (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/eyedropper.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/foreignobject-icons.xml (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/helloworld-icon.xml (added) (history) /trunk/extensions/SVGEdit/svg-edit/extensions/markers-icons.xml (added) (history) /trunk/extensions/SVGEdit/svg-edit/images (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/README.txt (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-bottom.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-bottom.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-center.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-center.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-left.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-left.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-middle.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-middle.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-right.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-right.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-top.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/align-top.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/bold.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/cancel.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/circle.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/clear.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/clone.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/conn.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/copy.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/cut.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/delete.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/document-properties.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/dropdown.gif (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/ellipse.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/eye.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/fhpath.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/flyouth.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/flyup.gif (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/freehand-circle.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/freehand-square.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/go-down.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/go-up.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/image.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/italic.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/line.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/link_controls.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/logo.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/logo.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/move_bottom.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/move_top.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/node_clone.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/node_delete.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/none.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/open.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/paste.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/path.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/polygon.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/polygon.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/rect.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/redo.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/reorient.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/rotate.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/save.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/select.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/select_node.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/sep.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/shape_group.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/shape_ungroup.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/source.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/spinbtn_updn_big.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/square.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/svg_edit_icons.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/svg_edit_icons.svgz (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/text.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/text.svg (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/to_path.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/undo.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/view-refresh.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/wave.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/wireframe.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/images/zoom.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/LICENSE (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/README (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/css (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/css/jPicker-1.0.12.css (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/css/jgraduate.css (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/AlphaBar.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/Bars.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/Maps.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/NoColor.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/bar-opacity.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/map-opacity.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/mappoint.gif (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/mappoint_c.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/mappoint_f.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/picker.gif (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/preview-opacity.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/rangearrows.gif (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/images/rangearrows2.gif (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/jpicker-1.0.12.min.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/jquery.jgraduate.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/jgraduate/jquery.jgraduate.min.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/jquery-ui (added) (history) /trunk/extensions/SVGEdit/svg-edit/jquery-ui/jquery-ui-1.8.custom.min.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/jquery.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/jquerybbq (added) (history) /trunk/extensions/SVGEdit/svg-edit/jquerybbq/jquery.bbq.min.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/js-hotkeys (added) (history) /trunk/extensions/SVGEdit/svg-edit/js-hotkeys/README.md (added) (history) /trunk/extensions/SVGEdit/svg-edit/js-hotkeys/jquery.hotkeys.min.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/README.txt (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.af.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.ar.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.az.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.be.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.bg.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.ca.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.cs.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.cy.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.da.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.de.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.el.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.en.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.es.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.et.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.fa.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.fi.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.fr.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.fy.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.ga.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.gl.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.he.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.hi.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.hr.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.hu.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.hy.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.id.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.is.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.it.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.ja.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.ko.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.lt.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.lv.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.mk.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.ms.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.mt.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.nl.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.no.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.pl.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.pt-BR.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.pt-PT.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.ro.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.ru.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.sk.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.sl.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.sq.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.sr.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.sv.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.sw.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.th.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.tl.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.tr.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.uk.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.vi.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.yi.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.zh-CN.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.zh-HK.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/lang.zh-TW.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/locale.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/locale/locale.min.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/spinbtn (added) (history) /trunk/extensions/SVGEdit/svg-edit/spinbtn/JQuerySpinBtn.css (added) (history) /trunk/extensions/SVGEdit/svg-edit/spinbtn/JQuerySpinBtn.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/spinbtn/JQuerySpinBtn.min.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/spinbtn/spinbtn_updn.png (added) (history) /trunk/extensions/SVGEdit/svg-edit/svg-editor.css (added) (history) /trunk/extensions/SVGEdit/svg-edit/svg-editor.html (added) (history) /trunk/extensions/SVGEdit/svg-edit/svg-editor.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/svg-editor.manifest (added) (history) /trunk/extensions/SVGEdit/svg-edit/svg-editor.min.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/svgcanvas.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/svgcanvas.min.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/svgicons (added) (history) /trunk/extensions/SVGEdit/svg-edit/svgicons/jquery.svgicons.js (added) (history) /trunk/extensions/SVGEdit/svg-edit/svgicons/jquery.svgicons.min.js (added) (history)

Comments

#Comment by Nikerabbit (talk | contribs) 09:24, 22 November 2010

67	{"id": "stroke_color", "title": "Muuta aivohalvaus väri"},
68	{"id": "stroke_style", "title": "Muuta aivohalvaus Dash tyyli"},
69	{"id": "stroke_width", "title": "Muuta aivohalvaus leveys"},

Olol are these machine translated or what? Looks to be same for all languages.

#Comment by Brion VIBBER (talk | contribs) 17:38, 22 November 2010

Take it up upstream ;)

#Comment by Brion VIBBER (talk | contribs) 18:40, 22 November 2010

actually that reminds me -- I would have preferred to use SVN externals to pull in svg-edit from their SVN master on Google Code, but I'm not sure how to drop the ext-mediawiki.js into the extensions subdir or suppress the .php support files for the disabled server-assisted open/close extension.

If someone knows a good trick for that, it'd be easier to keep up to date since we could just switch the upstream pointer when new releases come out.

#Comment by Brion VIBBER (talk | contribs) 04:08, 24 January 2011

De-fixmeing; as noted above the only complaint was about localization files in a third-party library not being super great, which blocks neither deployment nor release of MediaWiki 1.17/1.18. (Actually, upstream is interested in moving to translatewiki.)

Status & tagging log

04:08, 24 January 2011 Brion VIBBER (talk | contribs) changed the status of r77096 [removed: fixme added: ok]
09:24, 22 November 2010 Nikerabbit (talk | contribs) changed the status of r77096 [removed: new added: fixme]