r77058 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77057‎ | r77058 | r77059 >
Date:15:19, 20 November 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Revert r76394 after r76806 and document in getInstallSteps() the existance of such messages.
Modified paths:
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -298,6 +298,8 @@
299299 /**
300300 * Get an array of install steps. These could be a plain key like the defaults
301301 * in $installSteps, or could be an array with a name and a specific callback
 302+ * There must be a config-install-$step message defined per step, which are
 303+ * shown by the CliInstaller.
302304 *
303305 * @param $installer DatabaseInstaller so we can make callbacks
304306 * @return array
Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -477,6 +477,7 @@
478478 'config-install-secretkey' => 'Generating secret key',
479479 'config-insecure-secret' => "'''Warning:''' Unable to create a secure <code>$1</code>.
480480 Consider changing it manually.",
 481+ 'config-install-upgradekey' => 'Generating default upgrade key',
481482 'config-install-sysop' => 'Creating administrator user account',
482483 'config-install-mainpage' => 'Creating main page with default content',
483484 'config-install-mainpage-failed' => 'Could not insert main page.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r77078Follow up r77058 per CRplatonides16:26, 21 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76394Followup r76391, r76393, rm unused msgdemon17:02, 9 November 2010
r76806Revert r76393 and make $wgUpgradeKey like $wgSecretKey. Followup for r76391platonides16:16, 16 November 2010

Comments

#Comment by 😂 (talk | contribs)   16:43, 20 November 2010

They're shown by WebInstaller too?

#Comment by Platonides (talk | contribs)   16:26, 21 November 2010

Hmm, right. I missed it in my grepping. Too much noise from Installer.i18n.php

Fixed in r77078.

Status & tagging log