r77005 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77004‎ | r77005 | r77006 >
Date:02:11, 19 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
fix part 2
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter3.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter4.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php
@@ -163,7 +163,7 @@
164164 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
165165 if ( $this->paypal ) {
166166 $form .= Html::hidden( 'PaypalRedirect', false );
167 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
 167+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';return true;', 'type' => 'submit' ) );
168168 } else {
169169 $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'type' => 'submit' ) );
170170 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter3.php
@@ -163,7 +163,7 @@
164164 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
165165 if ( $this->paypal ) {
166166 $form .= Html::hidden( 'PaypalRedirect', false );
167 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
 167+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';return true;', 'type' => 'submit' ) );
168168 } else {
169169 $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'type' => 'submit' ) );
170170 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter4.php
@@ -163,7 +163,7 @@
164164 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
165165 if ( $this->paypal ) {
166166 $form .= Html::hidden( 'PaypalRedirect', false );
167 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
 167+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';return true;', 'type' => 'submit' ) );
168168 } else {
169169 $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'type' => 'submit' ) );
170170 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php
@@ -118,7 +118,7 @@
119119 $form .= Html::hidden( 'PaypalRedirect', false );
120120 $form .= Xml::tags( 'div',
121121 array(),
122 - Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos2.gif" ) ) . '&nbsp;&nbsp;&nbsp;<a href="#" onclick="document.payment.PaypalRedirect.value=\'true\';document.payment.submit();"><img src="' . $scriptPath . '/donate_with_paypal.gif"/></a>'
 122+ Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos2.gif" ) ) . '&nbsp;&nbsp;&nbsp;<a href="#" onclick="document.payment.PaypalRedirect.value=\'true\';return true;"><img src="' . $scriptPath . '/donate_with_paypal.gif"/></a>'
123123 );
124124 $form .= '</td>';
125125 $form .= '</tr>';

Status & tagging log