r77004 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77003‎ | r77004 | r77005 >
Date:02:09, 19 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
fix for forms 5 and 6
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter6.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php
@@ -195,7 +195,7 @@
196196 // cc submit button
197197 $form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit' ) );
198198 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
199 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;document.payment.submit();', 'type' => 'submit' ) );
 199+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;return true;', 'type' => 'submit' ) );
200200 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
201201 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
202202 wfMsg( 'payflowpro_gateway-donate-click' );
@@ -206,7 +206,7 @@
207207 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit-paypal' ) );
208208 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
209209 $form .= Html::hidden( 'PaypalRedirect', 0 );
210 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=1;document.payment.submit();', 'type' => 'submit' ) );
 210+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=1;return true;', 'type' => 'submit' ) );
211211 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-donate-submessage
212212 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-form-submit
213213
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter6.php
@@ -208,7 +208,7 @@
209209 $form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit', 'style' => 'display: none;' ) );
210210 }
211211 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
212 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;document.payment.submit();', 'type' => 'submit' ) );
 212+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;return true;', 'type' => 'submit' ) );
213213 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
214214 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
215215 wfMsg( 'payflowpro_gateway-donate-click' );
@@ -223,7 +223,7 @@
224224 }
225225 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
226226 $form .= Html::hidden( 'PaypalRedirect', 0 );
227 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=1;document.payment.submit();', 'type' => 'submit' ) );
 227+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=1;return true;', 'type' => 'submit' ) );
228228 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-donate-submessage
229229 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-form-submit
230230 return $form;

Status & tagging log