r76965 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r76964‎ | r76965 | r76966 >
Date:21:30, 18 November 2010
Author:tparscal
Status:ok
Tags:
Comment:
Renamed article-feedback-wrapper to articleFeedback-wrapper, following a camelCase convention for multi-word concepts and - for dividing levels of structure
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
——@@ -27,7 +27,7 @@
2828 <option value="5">5</option> \
2929 </select> \
3030 </div>',
31 - 'structureHTML': '<div class="article-feedback-wrapper nonopopups"> \
 31+ 'structureHTML': '<div class="articleFeedback-wrapper nonopopups"> \
3232 <form action="rate" method="post" id="article-feedback"> \
3333 <fieldset id="article-feedback-rate"> \
3434 <legend></legend> \
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.css
——@@ -2,50 +2,50 @@
33 * Styles for Article Feedback
44 */
55
6 -.article-feedback-wrapper #article-feedback-rate,
7 -.article-feedback-wrapper #article-feedback-ratings {
 6+.articleFeedback-wrapper #article-feedback-rate,
 7+.articleFeedback-wrapper #article-feedback-ratings {
88 background: #f7f7f7;
99 float: left;
1010 }
1111
12 -.article-feedback-wrapper #article-feedback-rate {
 12+.articleFeedback-wrapper #article-feedback-rate {
1313 width: 650px;
1414 margin-right: 10px;
1515 }
16 -.article-feedback-wrapper legend {
 16+.articleFeedback-wrapper legend {
1717 font-weight: bold;
1818 }
19 -.article-feedback-wrapper .field-wrapper {
 19+.articleFeedback-wrapper .field-wrapper {
2020 float: left;
2121 width: 270px;
2222 padding-right: 28px;
2323 }
24 -.article-feedback-wrapper .rating-field {
 24+.articleFeedback-wrapper .rating-field {
2525 float: right;
2626 width: 125px;
2727 line-height: 24px;
2828 padding-right: 5px;
2929 }
30 -.article-feedback-wrapper .rating-field-label{
 30+.articleFeedback-wrapper .rating-field-label{
3131 float: left;
3232 font-weight: bold;
3333 line-height: 24px;
3434 }
35 -.article-feedback-wrapper .rating-field-label {
 35+.articleFeedback-wrapper .rating-field-label {
3636 margin-right: 10px;
3737 }
38 -.article-feedback-wrapper .rating-field-hint {
 38+.articleFeedback-wrapper .rating-field-hint {
3939 width: 11px;
4040 height: 24px;
4141 display: block;
4242 float: right;
4343 background: url(images/question.png) 0 50% no-repeat;
4444 }
45 -.article-feedback-wrapper .rating-field-hint:hover {
 45+.articleFeedback-wrapper .rating-field-hint:hover {
4646 background: url(images/question-hover.png) 0 50% no-repeat;
4747 }
4848
49 -.article-feedback-wrapper .article-feedback-flash {
 49+.articleFeedback-wrapper .article-feedback-flash {
5050 float: left;
5151 font-size: 11px;
5252 padding: 1px 5px;
——@@ -53,25 +53,25 @@
5454 text-align: left;
5555 display: block;
5656 }
57 -.article-feedback-wrapper .article-feedback-stale-msg {
 57+.articleFeedback-wrapper .article-feedback-stale-msg {
5858 background: #d6f3ff;
5959 border: 2px solid #5dc9f4;
6060 }
61 -.article-feedback-wrapper .article-feedback-success-msg {
 61+.articleFeedback-wrapper .article-feedback-success-msg {
6262 background: #e8e8e8;
6363 border: 2px solid #006505;
6464 }
65 -.article-feedback-wrapper .article-feedback-error-msg {
 65+.articleFeedback-wrapper .article-feedback-error-msg {
6666 background: #e8e8e8;
6767 border: 2px solid #a91100;
6868 }
69 -.article-feedback-wrapper .article-feedback-rating-field-name {
 69+.articleFeedback-wrapper .article-feedback-rating-field-name {
7070 float: left;
7171 width: 110px;
7272 font-weight: bold;
7373 font-size: 11px;
7474 }
75 -.article-feedback-wrapper .article-feedback-rating-field-value-wrapper {
 75+.articleFeedback-wrapper .article-feedback-rating-field-value-wrapper {
7676 background: url(images/rating-base.png) 0 0 no-repeat;
7777 width: 120px;
7878 height: 13px;
——@@ -81,29 +81,29 @@
8282 text-indent: -9999px;
8383 margin-top: 4px;
8484 }
85 -.article-feedback-wrapper .article-feedback-rate-instructions,
86 -.article-feedback-wrapper .article-feedback-rate-feedback,
87 -.article-feedback-wrapper .article-feedback-show-ratings,
88 -.article-feedback-wrapper .article-feedback-hide-ratings {
 85+.articleFeedback-wrapper .article-feedback-rate-instructions,
 86+.articleFeedback-wrapper .article-feedback-rate-feedback,
 87+.articleFeedback-wrapper .article-feedback-show-ratings,
 88+.articleFeedback-wrapper .article-feedback-hide-ratings {
8989 font-size: 11px;
9090 font-style: italic;
9191 }
92 -.article-feedback-wrapper .article-feedback-rate-instructions {
 92+.articleFeedback-wrapper .article-feedback-rate-instructions {
9393 float: left;
9494 }
95 -.article-feedback-wrapper .article-feedback-rate-feedback {
 95+.articleFeedback-wrapper .article-feedback-rate-feedback {
9696 float: right;
9797 }
98 -.article-feedback-wrapper .article-feedback-rating-field-value-wrapper .article-feedback-rating-field-value {
 98+.articleFeedback-wrapper .article-feedback-rating-field-value-wrapper .article-feedback-rating-field-value {
9999 background: url(images/rating-bar.png) 0 0 no-repeat;
100100 height: 9px;
101101 float: right;
102102 display: block;
103103 }
104 -.article-feedback-wrapper .article-feedback-rating-fields {
 104+.articleFeedback-wrapper .article-feedback-rating-fields {
105105 margin: 8px 0;
106106 }
107 -.article-feedback-wrapper .article-feedback-rating-fields .field-wrapper {
 107+.articleFeedback-wrapper .article-feedback-rating-fields .field-wrapper {
108108 margin-bottom: 5px;
109109 }
110110 .article-feedback-rating-count {
——@@ -115,17 +115,17 @@
116116 margin: 2px 0;
117117 float: right;
118118 }
119 -.article-feedback-wrapper .article-feedback-ratings-disabled .article-feedback-rating-field-value-wrapper {
 119+.articleFeedback-wrapper .article-feedback-ratings-disabled .article-feedback-rating-field-value-wrapper {
120120 background: urlimages/rating-base-disabled.png) 0 0 no-repeat;
121121 }
122 -.article-feedback-wrapper .article-feedback-ratings-disabled .article-feedback-rating-field-value {
 122+.articleFeedback-wrapper .article-feedback-ratings-disabled .article-feedback-rating-field-value {
123123 display: none;
124124 }
125 -.article-feedback-wrapper .article-feedback-ratings-disabled .article-feedback-rating-count {
 125+.articleFeedback-wrapper .article-feedback-ratings-disabled .article-feedback-rating-count {
126126 visibility: hidden;
127127
128128 }
129 -.article-feedback-wrapper .article-feedback-ratings-disabled .article-feedback-rating-field-name {
 129+.articleFeedback-wrapper .article-feedback-ratings-disabled .article-feedback-rating-field-name {
130130 color: #9f9f9f;
131131 }
132132
——@@ -148,39 +148,39 @@
149149
150150
151151 /* Self Clearing Floats */
152 -.article-feedback-wrapper .article-feedback-information:after,
153 -.article-feedback-wrapper .field-wrapper:after,
154 -.article-feedback-wrapper .article-feedback-rating-fields:after,
 152+.articleFeedback-wrapper .article-feedback-information:after,
 153+.articleFeedback-wrapper .field-wrapper:after,
 154+.articleFeedback-wrapper .article-feedback-rating-fields:after,
155155 .article-feedback-rating:after,
156 -.article-feedback-wrapper .article-feedback-submit:after,
157 -.article-feedback-wrapper .rating-fields:after {
 156+.articleFeedback-wrapper .article-feedback-submit:after,
 157+.articleFeedback-wrapper .rating-fields:after {
158158 content: ".";
159159 display: block;
160160 height: 0;
161161 clear: both;
162162 visibility: hidden;
163163 }
164 -.article-feedback-wrapper .field-wrapper,
165 -.article-feedback-wrapper .article-feedback-information,
166 -.article-feedback-wrapper .article-feedback-rating-fields,
 164+.articleFeedback-wrapper .field-wrapper,
 165+.articleFeedback-wrapper .article-feedback-information,
 166+.articleFeedback-wrapper .article-feedback-rating-fields,
167167 .article-feedback-rating,
168 -.article-feedback-wrapper .article-feedback-submit,
169 -.article-feedback-wrapper .rating-fields {
 168+.articleFeedback-wrapper .article-feedback-submit,
 169+.articleFeedback-wrapper .rating-fields {
170170 display: inline-block;
171171 }
172 -* html .article-feedback-wrapper .field-wrapper,
173 -* html .article-feedback-wrapper .article-feedback-information,
174 -* html .article-feedback-wrapper .article-feedback-rating-fields,
 172+* html .articleFeedback-wrapper .field-wrapper,
 173+* html .articleFeedback-wrapper .article-feedback-information,
 174+* html .articleFeedback-wrapper .article-feedback-rating-fields,
175175 * html .article-feedback-rating,
176 -* html .article-feedback-wrapper .article-feedback-submit,
177 -* html .article-feedback-wrapper .rating-fields {
 176+* html .articleFeedback-wrapper .article-feedback-submit,
 177+* html .articleFeedback-wrapper .rating-fields {
178178 height: 1%;
179179 }
180 -.article-feedback-wrapper .field-wrapper,
181 -.article-feedback-wrapper .article-feedback-information,
182 -.article-feedback-wrapper .article-feedback-rating-fields,
 180+.articleFeedback-wrapper .field-wrapper,
 181+.articleFeedback-wrapper .article-feedback-information,
 182+.articleFeedback-wrapper .article-feedback-rating-fields,
183183 .article-feedback-rating,
184 -.article-feedback-wrapper .article-feedback-submit,
185 -.article-feedback-wrapper .rating-fields {
 184+.articleFeedback-wrapper .article-feedback-submit,
 185+.articleFeedback-wrapper .rating-fields {
186186 display: block;
187187 }
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r77648Part 3 of r77646: reapply r76964, r76965, r76966catrope13:33, 3 December 2010

Status & tagging log